Dark Forest Loot Chests are Empty with Quark Installed
jahess-it opened this issue ยท 3 comments
Minecraft version: 1.16.5
Forge version: 36.1.16
Twilight Forest version: 4.0.435
Quark version: r2.4-311
List of mods installed (with version numbers)
- AutoRegLib-1.6-47
- BlockArmor-2.6.1
- citadel-1.6.2
- curios-forge-4.0.5.1
- Easymagic-v1.0.2
- EffectEnchantments_MC_1.16.4_Vers.1.1.5
- EpicFightMod-3.2.2
- gravestone-1.0.6
- jei-7.6.4.90
- luckyblock-1.16.5-1
- Mantle-1.6.92
- Mr. Crayfish's Furniture Mod v7.0.0-pre19
- Mr. Crayfish's Vehicle Mod 0.45.2
- NetherPortalFix-7.2.1
- obfuscate-0.6.1
- Patchouli-1.16.4-50
- polymorph-0.24
- Quark-r2.4-311
- rats-7.1.1
- secretrooms-1.0.1
- Sneakyagic-v1.3.2
- sophisticatedbackpacks-2.4.0.259
- SpartanMetals-v2.1.1
- SpartanWeaponry-2.1.0-beta4
- TConstruct-3.0.3.136
- twilightforest-4.0.435 (obviously)
Link to crash log: https://gist.github.com/jahess-it/9ff9ac8b11d8d65b30d84f0f4c14c729
Steps to reproduce:
- Go to Twilight Forest dimesion.
- Go to the Dark Forest biome.
- Find a loot chest.
- Open it.
What I expected to happen:
Loot chest should have loot in it when opened.
What happened instead:
Loot chest is empty when opened. Interestingly enough, loot chest drops its contents without error if broken before it is opened.
Let me know if there is anything else you need. Thank you for your time.
Since there hasn't been any further communication we'll be closing this. If the issue persists feel free to update and re-open this issue.
This issue doesn't appear to be caused by TF.
From what it looks like, if the chest is opened, there is an error from quark related to something called "blockArmor"? There's a few things that appear to be throwing me off trying to read that crash log. Might I suggest trying out TF version 4.0.467? Two of our unused enchantments were removed in that version. If it doesn't, I would say this is an issue for quark.
Looks like Block Armor expects context.get(LootParameters.TOOL)
to always return something here despite the method being marked as nullable.
Vanilla EnchantmentHelper#getEnchantments
also calls ItemStack#getItem
without a null check just like Quark does, so I would say this is purely Block Armor's fault. Are you wearing some of their armor?