The Twilight Forest

The Twilight Forest

140M Downloads

[1.19.3] Portals delink overworld->TF when the end location is in a locked biome

Shedao-Shai opened this issue ยท 5 comments

commented

Forge Version

44.1.17

Twilight Forest Version

4.2.1604

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

  1. Light a portal in the overworld in a location that would put the TF side in a locked biome
  2. Go through the portal multiple times

What You Expected

I expected the portal to remain linked both ways

What Happened Instead

Every time I entered the TF it would create a new portal somewhat close to the old portal, however all of these portals would remain linked to the one Overworld portal (so 1 overworld portal creates a number of TF-side portals).

Additional Details

I have a feeling this is related to the recent fix regarding dimension scaling

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
commented

Here's a fun addition, after breaking the extra two portals in the TF when I enter the TF I get dropped at the location of the broken portal, but it does not generate a new one so I just get dropped in a puddle. The original portal in the TF is still lit, so I have no clue what kind of logic is going on rn

commented

I know why that last one happens, oversight by me.

commented

So what's going on is the original player made portal isnt linking every single portal block to the dest location, so when you go through a different BlockPos each time it'll end up in a new location.

When the portal is linked for the very first time we can use TFPortalBlock#recursivelyValidatePortal to get a list of BlockPos of the source portal to then store in the linking system to the same dest location.

commented

I have no idea how that's even possible

commented

It's happened three or four times on a sp world, one overworld portal has generated multiple TF portals around a highlands biome