The Twilight Forest

The Twilight Forest

143M Downloads

[Compat Bug] - Charm of Keeping Deletes All Items when CosmeticArmorReworked is installed

AriaElidove opened this issue · 2 comments

commented

NeoForge Version

20.6.119

Twilight Forest Version

4.5.2490

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

Die while having a Charm of Keeping (any) in inventory.

What You Expected

Items to stay with the player upon respawning (and appropriate excess items to be dropped on the ground when applicable).

What Happened Instead

Items are completely wiped.

Additional Details

I was meaning to report a related issue regarding Charms of Keeping and Cosmetic Armor Reworked where Charms of Keeping would erase any/all Cosmetic Armor in 1.20.4, but now the complete opposite happens in 1.20.6 where JUST Cosmetic Armor is kept (regardless of tier)

I'm just reporting it here in case there is something TF sided rather than CA's

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
commented

I've been stood corrected; in 1.20.4, the items are NOT erased, but they are simply not kept with the player, even with CoK3.

commented

no longer an issue in 1.21 thanks to #2155. We never should've passed null into the inventory and 1.20.5 exposed why that was an issue due to saving stacks to nbt.

I added support for keeping cosmetic armor in 4409cf7. Should've done this a long time ago but whatevz