The Twilight Forest

The Twilight Forest

Mods
154M Downloads

FoliageColorHandler is not thread safe

DBotThePony opened this issue ยท 0 comments

commented

NeoForge Version

21.1.122

Twilight Forest Version

4.6.3003

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

  1. Install Distant Horizons and Twilight Forest
  2. Install mods/datapacks which add more biomes (not strict requirement, but helps with triggering the issue easier)
  3. Repeatedly join world and then restart the game until Distant Horizons threads get stuck inside FoliageColorHandler#get -> WeakHashMap#get or crash due to race condition

What You Expected

No crash nor no deadlock due to race condition

What Happened Instead

Distant Horizon threads stuck inside Twilight Forest code forever, or they crash

Image

Additional Details

No response

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.