NeoForge Version

40.2.21

Twilight Forest Version

4.1.1494

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

1. Add any sort of player-kill-entity detection (in my case it's FTB Quest for killing a Snow queen entity)
2. Kill Snow Queen

To check for damage source via KubeJS:

onEvent('entity.death', event => {
    const { entity } = event;
    if (entity.type == 'twilightforest:snow_queen') {
        event.server.tell(event.source);
        console.log(event.source);
    }
});

What You Expected

Kill is detected, quest is completed.

What Happened Instead

Kill is not detected, quest is not completed.

Additional Details

With testing via KubeJS it became known that the damage source used on death event is twilightforest.squish instead of whatever player inflicted and any attempt to get player from that source return null.

Additionally, if you name her (via nametag, KubeJS or otherwise) it even shows so in logs (see picture).

Please Read and Confirm The Following

• I have confirmed this bug can be replicated without the use of Optifine.
• I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
• I have confirmed this issue is unique and has not been reported already.

All versions once again:
TF: 4.1.1494
MC: 1.18.2 (I know it's not supported for updates, but I'm not asking for update/backport)
Forge: 40.2.21
KJS: 1802.5.5-build.269

Looked through the code for Snow Queen a bit.
I wonder if this may be the cause

seems to have been fixed sometime in between 1.18 and 1.21

That's...very nice and all, I suppose, but the 4.1.1494 is the last 1.18 version

meaning that the bug is very much present in 1.18 and is preventing accurate player kill detection (for multiple people across multiple mod packs).

I would very much appreaciate if a single line 317 would be changed from TFDamageSources.SQUISH to source. 🙏

We don't do backports to older versions. 1.18.2 is 3 and a half years old at this point.

I will not devolve into MC version's age vs. viability discussion, that is irrelevant, we're not on Bedrock Edition.
I'm not asking for backport or for new feature or whatever, nor I ever expected one, I'm asking for bugfix.
A bugfix for a version it's reported in.
A bugfix within a single line for that matter. Properly passing a parameter to a method of a superclass.

Its less of how difficult the backport/bugfix is, and more of the expectation it sets with people. I dont need people coming to ask me about fixing/backporting something on a version we havent touched/updated in years and citing something like this ("you fixed this damage bug in 1.18, why cant you fix X and Y for me too?"). I barely have time to work on this project as it is, I dont need my todo list flooded with asks like this when we already make it painfully clear that we stick to 1 version. Please dont fight us on this