Portal to TF is not the return portal; portal gen placement locs & links may need review
hanleybrand opened this issue · 2 comments
Forge version: forge-14.23.3.2670
Twilight Forest version: 1.12.2-3.6.345
Link to crash log: no crash, unexpected behavior - but here is the debug log:
debug.log -- events at [09:33:38] [10:01:22] [10:06:40] [10:23:04]
Seed: -3017967968402554725 . [note - I previously copied the wrong seed, sorry]
Steps to reproduce:
- create a portal (using a ruins template for full disclosure)
What I expected to happen: To be transported to TF in one of the 1st tier biomes
What happened instead:
This might be related to #465, as the issue I encountered was similar at the end - but the portal I used* spawned inside of a Hollow Hill (yikes! - I mean, not the hugest deal but I don't think that used to happen, especially since there's no grass inside the hollow hill, so it had to be created and it was floating above the ground)
When I went back to Dim 0 a new portal was created a few hundred blocks from the original portal instead of going to the one that was created -- and the portal was also underwater as in #465
I'm guessing the issue is that the portal I created would be linked into a locked/upper tier TF biome, and so found a 'safer' spot (Safely rerouted to long range portal. Return trip not guaranteed.) but then the safer spot linked back to a spot on the ocean in Dim 0 - this seems important, because the expected behavior would be a return trip (unless the player made a bunch of portals close to one another, I guess - in previous versions that was always a bit unstable)
filtered excerpt from debug log
[09:33:38] [Server thread/DEBUG] [twilightforest]: Player hanleybrand respawned and received items held in storage
[09:34:05] [Server thread/DEBUG] [twilightforest]: Player hanleybrand respawned and received items held in storage
[09:53:59] [Server thread/DEBUG] [twilightforest]: Player touched the portal block. Sending the player to dimension 7
[09:53:59] [Server thread/INFO] [twilightforest]: Ice Tower @ -280 32 280
[09:54:00] [Server thread/INFO] [twilightforest]: Yeti Cave @ -200 32 552
[09:54:03] [Server thread/INFO] [twilightforest]: Hedge Maze @ 8 32 8
[09:54:07] [Server thread/INFO] [twilightforest]: Yeti Cave @ 8 32 232
[09:54:09] [Server thread/INFO] [twilightforest]: Hill 3 @ 40 32 552
[09:54:18] [Server thread/DEBUG] [twilightforest]: Portal destination looks unsafe, rerouting!
[09:54:18] [Server thread/DEBUG] [twilightforest]: Did not find a safe spot at first try, trying again with longer range.
[09:54:18] [Server thread/DEBUG] [twilightforest]: Safely rerouted to long range portal. Return trip not guaranteed.
[09:54:18] [Server thread/DEBUG] [twilightforest]: Did not find ideal portal spot, shooting for okay one
[09:54:19] [Server thread/DEBUG] [twilightforest]: Found okay portal spot
[09:54:19] [Server thread/INFO] [twilightforest]: Hill 1 @ -248 32 776
[09:54:19] [Server thread/INFO] [twilightforest]: Naga Courtyard @ 24 32 808
[09:54:28] [Server thread/INFO] [twilightforest]: Hill 3 @ 264 32 264
[09:54:28] [Server thread/INFO] [twilightforest]: Hill 1 @ 264 32 488
[09:59:11] [Server thread/DEBUG] [twilightforest]: Did not find ideal portal spot, shooting for okay one
[09:59:12] [Server thread/DEBUG] [twilightforest]: Did not even find an okay portal spot, just making a random one
[10:01:22] [Server thread/DEBUG] [twilightforest]: Player touched the portal block. Sending the player to dimension 7
[10:06:40] [Server thread/DEBUG] [twilightforest]: Player touched the portal block. Sending the player to dimension 7
[10:06:42] [Server thread/DEBUG] [twilightforest]: Portal destination looks unsafe, rerouting!
[10:06:42] [Server thread/DEBUG] [twilightforest]: Did not find a safe spot at first try, trying again with longer range.
[10:06:42] [Server thread/DEBUG] [twilightforest]: Safely rerouted to long range portal. Return trip not guaranteed.
[10:06:42] [Server thread/DEBUG] [twilightforest]: Did not find ideal portal spot, shooting for okay one
[10:06:42] [Server thread/DEBUG] [twilightforest]: Found okay portal spot
Maps
mod list ( I realize this doesn't make things easier - I'll try to make a base TF instance and see if it still happens)
[1.12] RPG-HUD-3.6.6.2.jar
[1.12]MoVillages-1.5.4.jar
antiqueatlas-1.12.2-4.4.7.jar
backpacks 1.12.2 - 3.5.0.jar
Baubles-1.12-1.5.2.jar
BetterQuesting-3.5.253.jar
ChestTransporter-1.12.2-2.8.8.jar
CookingForBlockheads_1.12.2-6.3.26.jar
CraftTweaker2-1.12-4.1.8.jar
DimensionalDoors-3.0.8-271.jar
dirt2path-1.7.0.jar
DynamicLights-1.12.2.jar
Electroblob's Wizardry - 4.1.1 - MC 1.12.2.jar
FriendlyFire-1.12.2-1.5.8.jar
FTBLib-5.0.2.10.jar
FTBUtilities-5.0.2.10.jar
Hwyla-1.8.24-B39_1.12.jar
InfernalMobs-1.12.2.jar
InventoryTweaks-1.63.jar
jei_1.12.2-4.9.1.168.jar
jeiintegration_1.12.2-1.5.1.36.jar
jeivillagers-1.12-1.0.2.jar
jepb-1.12-1.2.1.jar
journeymap-1.12.2-5.5.2.jar
JustEnoughResources-1.12.2-0.8.5.27.jar
lostcities-1.12-2.0.7.jar
lostsouls-1.12-1.1.4.jar
MagicArsenal-MC1.12_ver1.1.0.jar
magicmirror 1.1 [1.12].jar
millenaire-1.12.2-6.2.0.jar
mobends-0.24_for_MC-1.12.jar
modtweaker-4.0.10.jar
MPUtils-1.12.2-1.5.4.jar
MTLib-3.0.4.jar
OptiFine_1.12.2_HD_U_D1.jar
questbook-3.1.1-1.12.jar
QuickLeafDecay-MC1.12.1-1.2.4.jar
RandomThings-MC1.12.2-4.1.5.jar
Ruins-1.12.2.jar
SereneSeasons-1.12.2-1.1.5-universal.jar
StandardExpansion-3.4.141.jar
Thaumcraft-1.12.2-6.1.BETA11.jar
ThaumicJEI-1.12.2-1.2.2-5.jar
tombstone-2.9.0-1.12.jar
twilightforest-1.12.2-3.6.345-universal.jar
VillageNames-1.12.2-2.0.jar
WailaHarvestability-mc1.12-1.1.12.jar
Waystones_1.12.2-4.0.42.jar
WorldEdit CUI Forge Edition 2-2.1.2-mf-1.12.2-14.23.0.2487.jar
worldedit-forge-mc1.12-6.1.8-dist.jar
redirecting this to #1459 so we can keep track of every portal issue in 1 place
ugh I just realized that I copied the wrong seed -- updating issue above
I tried recreating this issue with just TF (and journey map, but that shouldn't effect worldgen) and with thaumcraft etc out of the picture the worldgen in dim0 is a little different, but the same basic thing happened - a portal created (the normal way with a water bucket, flowers and a diamond) at -123 ~ 291 ends up having a hard time finding a landing spot in TF, and the return trip is to the same coords (still in an ocean 😃):
[13:52:16] [Server thread/DEBUG] [twilightforest]: Player touched the portal block. Sending the player to dimension 7
...
[13:52:16] [Server thread/INFO] [twilightforest]: Ice Tower @ -280 32 280
[13:52:17] [Server thread/INFO] [twilightforest]: Yeti Cave @ -200 32 552
...
[13:52:20] [Server thread/INFO] [twilightforest]: Hedge Maze @ 8 32 8
[13:52:25] [Server thread/INFO] [twilightforest]: Yeti Cave @ 8 32 232
[13:52:27] [Server thread/INFO] [twilightforest]: Hill 3 @ 40 32 552
[13:52:45] [Server thread/DEBUG] [twilightforest]: Portal destination looks unsafe, rerouting!
[13:52:45] [Server thread/DEBUG] [twilightforest]: Did not find a safe spot at first try, trying again with longer range.
[13:52:45] [Server thread/DEBUG] [twilightforest]: Safely rerouted to long range portal. Return trip not guaranteed.
[13:52:46] [Server thread/DEBUG] [twilightforest]: Did not find ideal portal spot, shooting for okay one
[13:52:46] [Server thread/DEBUG] [twilightforest]: Found okay portal spot
[13:52:46] [Server thread/INFO] [twilightforest]: Hill 1 @ -248 32 776
[13:52:48] [Server thread/INFO] [twilightforest]: Naga Courtyard @ 24 32 808
[13:53:07] [Server thread/INFO] [twilightforest]: Hill 3 @ 264 32 264
[13:53:07] [Server thread/INFO] [twilightforest]: Hill 1 @ 264 32 488