The Twilight Forest

The Twilight Forest

143M Downloads

[1.13] Split major structures into different structures

williewillus opened this issue · 5 comments

commented

currently literally everything is dumped into the single type TFFeature.

benefits of splitting it:

  • advancements can query which one you're in (minecraft:location trigger)
  • /locate can find specific structure types
  • exploration maps can point to specific types
  • cleaner code
commented

This was completed when 1.14 rolled around

commented
commented

So since I hear 1.13 is going still be a ways off, and Forge 1.13 even further off, I may just handle this now.

A Datafixer can be applied to move id key FeatureID to the actual structure ID key id, making this practically trivial to handle in the immediate future instead.

commented

Partially handled via 4c9ffe5

commented

Soooo... Turns out I'd not only have to apply a datafixer, but I'd need to move them into their own NBT files 🤦‍♂️