The Twilight Forest

Steps to reproduce:

Fight ur-ghast until it begins its tantrum

What I expected to happen:

Giant ghast tears fall and shatter under the boss

What happened instead:

No visible tears, player takes damage from no apparent source

Done via proxy, so only works on singleplayer client atm:

twilightforest/src/main/java/twilightforest/entity/boss/EntityTFUrGhast.java

Line 344 in cbfd798

    
           TwilightForestMod.proxy.spawnParticle(this.world, TFParticleType.BOSS_TEAR, this.posX + (this.rand.nextDouble() - 0.5D) * (double) this.width, this.posY + this.rand.nextDouble() * (double) this.height - 0.25D, this.posZ + (this.rand.nextDouble() - 0.5D) * (double) this.width, 0, 0, 0);

The particle spawning here could be moved to the Ur-Ghast's onLivingUpdate, the AI code only runs on the logical server.

It might also be better to check getPrecipitationHeight here instead of canSeeSky:

twilightforest/src/main/java/twilightforest/entity/boss/EntityTFUrGhast.java

Line 364 in e9752dc

if (world.canSeeSky(new BlockPos(player))) {

(canSeeSky uses the heightmap based on block opacity, whereas getPrecipitationHeight checks the block material, matching rainfall probably makes more sense here)

I'm unsure how to handle that check for the getPrecipitationHeight, could you clarify that, please?

Share to