The Twilight Forest

The Twilight Forest

Mods
143M Downloads

Ghast trap advancement does not fire in the expected area

Hubry opened this issue ยท 4 comments

commented

Forge version: 14.23.5.2772
Twilight Forest version: 3.8.689
Link to crash log: n/a

Steps to reproduce:

  1. Run a dedicated server.
  2. Activate a charged ghast trap (3+ ghastlings killed nearby) with a redstone signal while standing close to it in a certain area around the trap . An Ur-ghast is optional.

What I expected to happen: The advancement is given to the player.
What happened instead: The ghast trap fires but advancement is not given.

(pack is Wikipack 3.2 but I have seen this happen on the previous iteration of the official TF server.)

commented

Does the trophy pedestal advancement work fine on a dedicated server?

If so, does build 735+ work?

commented

I'm gonna blame this:

twilightforest/src/main/java/twilightforest/block/BlockTFTowerDevice.java

Line 237 in f43b214

List<Entity> entities = world.getEntitiesWithinAABBExcludingEntity(null, new AxisAlignedBB(pos.getX() - 6, pos.getY() - 6, pos.getZ() - 6, pos.getX() + 6, pos.getZ() + 6, pos.getZ() + 6));

commented

Yes, the trophy pedestal one worked fine every time I tried so far.

So I was just unlucky by always activating the traps when standing in the wrong area, but only when playing on a server? Welp, correcting the issue now...

commented

Thanks for checking. As the trophy pedestal advancement triggers fine, then this is probably just that bounding box issue, which is fixed by 9e38c2f.