The Twilight Forest

The Twilight Forest

143M Downloads

Naga spawning in Overworld in normal vanilla biomes

Gunner76th opened this issue ยท 19 comments

commented

Forge version:
Twilight Forest version: (this is the build number) twilightforest-1.12.2-3.10.1013-universal
Link to crash log: (please use a paste site such as gist, do not attach the .txt or paste the log inline)
Not applicable as it is not a crash, but rather a possible mod conflict issue.

Steps to reproduce:

  1. Install version 1.39 of the Roguelike Adventures and Dungeons modpack from Curseforge: https://www.curseforge.com/minecraft/modpacks/roguelike-adventures-and-dungeons

  2. Create a world, and then explore. The frequency with which it happens seems to be random.

  3. I do not know if this will help replicate the issue, however please try using Seed: -4403913139813209694

  4. Once the world is created using the Seed in step 3, proceed to the coordinates at X: -1387 Z: 1059

What I expected to happen: We expect a world to be generated like normal, with TLF boss mobs NOT spawning in the overworld or any other dimension.

What happened instead: World are being generated as normal, however TLF Boss mobs (specifically the Naga so far) are being spawned outside of the TLF Dimension.

Included is a copy of one of the user's latest.log file who is experiencing this issue. This log file belongs to the world created with the Seed listed in step 3. If there is anything else you require, please let us know. You can also come to Dreams01's Discord to speak with us directly regarding this issue by using this link: https://discord.gg/ZsrYtDb
latest (15).log
Log was not posted as a Gist as Gist has been having issues recently.

commented

PG85/OpenTerrainGenerator#339

So just discovered this issue. While RAD does not have Mo 'Creatures in the modpack (and neither did the author's list in his original post) it looks like this is pointing towards the cause. Now, while RAD is using V6 of OTG, I am curious if this issue is not also in that version as well, and was only reported for V8 as that is the most current.

When the issue is present, in OTG worlds mod mobs can spawn as other mod's mobs if that other mod's mob shares the same or similar name. The biggest example of this is with mowzies mobs naga being replaced by twilight forest naga

commented

If this is the case, then it literally means that the issue can only be reproduced by loading up the registered entity list on pack load, and that testing by traditional means of testing each mod separately would never work. I am going to load a standard RAD instance, and use the /otg commands mentioned and see what it replies with.

commented

image
And this confirms the issue, it IS OTG causing the problem as reported in the post above. When in the Overworld, in certain biomes (Stone Beach for instance) OTG is calling the EntityTFNaga instead of the EntityNaga from Mowzie.

So either we have to wait for this to be fixed and released in V9 of OTG, or see if there is a way that TLF can encase the Naga and other boss mobs in such a way that no other mod can call them. Is that even possible within the limitations of java code?

commented

Not possible on our end.

commented

Here's the stupid thing, entity registry names have a namespace, how does a mod fuck up that badly.

commented

I don't know, but as you can see, OTG can and is.

commented

But at least now the different documentation related to this, as well as the ultimate cause is in a single thread. I only happened to stumble upon that issue on OTG by accident while doing various Google searches, and it had not shown up before. Thank you for help, and hopefully we can figure out a way to deal with this until OTG fixes their code.

commented

image
And as expected OTG did in fact spawn in the wrong naga.

commented

Definitely another mod doing this, not an issue from our side of things

commented

Which is why I have presented this here, so that you can help identify WHY this is happening. We have checked the OTG files, and I am not seeing any references to anything there. I was hoping since you work on the code, you might have a better understanding of how it works, and possibly notice something happening while trying to recreate the issue with the steps above that would point to the cause.

commented

Have you even attempted doing a conflict search such as a binary mod removal search...

Remove mods until the issue is gone, track down the exact mod doing this.

commented

Another thing you could have tried, replicate this in peaceful to see if it's the spawner block itself being placed as those won't trigger in peaceful. If this is the case then some mod is placing our block. That could also help with a lead to whatever mod.

Our mod doesn't even add any of our bosses to any biome spawn list. Some mod is deliberately using our block or entities. There's no way for me to know and I'm not going to download an entire pack to do a removal search when you guys could ๐Ÿ˜›

commented

After some initial online research, I came across these issues related to biome problems between TLF and OTG/Biome Bundle. Since the biome involved (to my knowledge) with the issue we are seeing is almost exclusively the Forest, and if memory servers, the Naga Arena is spawned in TLF Forest areas, it feels like this might be related at some level.

PG85/OpenTerrainGenerator#76
BiomeBundle/BiomeBundle#105
BiomeBundle/BiomeBundle#154

commented

Again, not saying this IS but its giving me an idea on places to start with. It's already been documented in the past that OTG/Biome Bundle and TLF have had issues with each other.

commented

OTG issue is completely unrelated and closed for that matter.
Ok biome bundle, sounds like it's their issue, ok! Remove mod, issue gone? Good! Go bug that dev to fix it! Not solved? Uh oh time to start searching for the actual mod at fault then bug them ๐Ÿค”

I'm telling you now, there's nothing in our code that could be causing this that we can fix from our side of things.

commented

Oof they're closed source so I can't even do actual digging into their code without decompilation and using BON2

Wait this is an OTG add-on ๐Ÿค”

commented

As a start, I am testing just TLF, OTG/Biome Bundle on forge 2854. With the evidence so far, that seems like a logical place to start. At the moment I am not encountering any Naga spawning. I used the Seed above, went to the location, and I am using all of the configs from RAD for testing. So far nothing is happening. At the moment, it looks like its not OTG/BB causing this, but it could be that I need to wait a bit, perhaps for nightfall.

commented

Ok, so after some further review and consult with some of our helpers, it seems the issue was not present in 1.38 but started in 1.39. This helps isolate the issue from a list of 138 mods down to 38, since that is how many had updates between the 2 versions.
If anything in this change log jumps out at you as a possible culprit please let us know. https://pastebin.com/raw/P2FXPsH6

commented

Closing as it is an OTG problem, and also should no longer happen in 1.16.