The Vanilla Experience (Mod) (Forge)

The Vanilla Experience (Mod) (Forge)

118k Downloads

Compatibility for mods adding Grindstone variants

Closed this issue ยท 3 comments

commented

Information

Minecraft version: 1.20.1 - 1.21.5
Modloader: Fabric

Mod name: Grindstone Sharper Tools

Feature description

So, first of all, I want to take this opportunity to thank you for creating these mods and in the way you do, you've been a huge inspiration and one of the reasons I got into modding in the first place.
Now, a user of my own mod "More Grindstone Variants" came to me asking for compatibility with "Grindstone Sharper Tools". (pnk2u/More-Grindstone-Variants#7)
I assumed correctly that the issue they can't use the mod's newly added Sharpening functionality with my Grindstone Variants is that Grindstone Sharper Tools checks for the Block (block.equals(Blocks.GRINDSTONE)) instead of checking for the Block class (block instanceof GrindstoneBlock) which I tend to favor and would prevent the incompatibility.
Do you think this would be possible to change on your end and release an update or is there some issue with that I'm missing? Otherwise I'd have to Mixin into your GrindEvent class which is possible but I'd really like to not have to do that. :D

commented

If it'd help, I'd be happy to send a PR into Grindstone Sharper Tools' Repo, let me know if there's a certain branch you'd prefer for that or if you'd like me to PR all actively developed branches. If not, I would just PR into the default branch (1.21.5).

commented

I'm glad you've been enjoying the mods!

I just released version 3.9 which checks for instanceof GrindstoneBlock. Hope that fixes the incompatibility :)

commented

Thanks a lot, works exactly as expected! (: