The Vegan Option

The Vegan Option

53.9k Downloads

JEI: Make fluid containers and fluids have the same recipes/usages

squeek502 opened this issue ยท 0 comments

commented

This has been split from #71. Relevant comments from that issue:

Also, with the description stuff working properly, the "Make fluid containers and fluids have the same recipes/usages" thing is not as important, since I believe all bottled fluids link to their fluid blocks with the byproducts/byproduct of sections. I think we should focus on the few remaining things and hold off on this bit (will make a separate issue for it and remove it from this checklist).


Regarding "Make fluid containers and fluids have the same recipes/usages," it might be better to simply use the fluid containers for the recipes/usages, and then to blacklist the fluid blocks from showing up at all in JEI. What do you think?


This is complicated by the fact that certain things will output/use contained fluids, and certain things will output/use fluid blocks from the world. So, if everything shows up as a contained fluid, that divide will be confusing (for example, piston crafting showing input/output of bottled fluid, when that is not how it works).

It might be possible to get around this, though, by making what shows up in JEI independent of what gets set as the input/output in the Wrapper implementations (e.g. IRecipeWrapper.getIngredients sets the bottled fluid as the input, but the category implementation sets the slot to the fluid block--this is kind of what 036f5ab did). I'll look into this more and see what's possible.