The Wild Mod [Fabric]

The Wild Mod [Fabric]

658k Downloads

Mod Conflict "See through lava"

KMFrench1 opened this issue ยท 9 comments

commented

The ability's to see through lava that other mods add stops working if I install this mod.

Example mod that conflicts:
https://www.curseforge.com/minecraft/mc-mods/see-through-lava-water

commented

This is because we use overrides that sets the lava fog to default if the player doesn't have darkness. The reason we have it like that is because otherwise there would be a desync after the fog is finished pulsing. For now, I'll be marking this as won't fix as we have no other viable solution.

commented

Do you have any mods that change the rendering/fog in the game? If not, then perhaps this problem is caused by the darkness effect.

commented

Do you have any mods that change the rendering/fog in the game? If not, then perhaps this problem is caused by the darkness effect.

that other mods add

@Soro335
It's a problem with both

commented

its probably a problem related to darkness effect, since i completely overrided the rendering method. Ill try to find a better way to return a darkness effect instead of completely remove the vanilla rendering method

commented

i hopefully fixed this issue. From now the code will only override the vanilla rendering while theres darkness, not in full time.

@MerpisMe & @AViewFromTheTop also you should not put a sound effect in a rendering class, it does not do anything wrong, but its meant for rendering... well does not mean you have to change something just wanted to let you know
image

commented

is there a "hopefully fixed" button or something

commented

i hopefully fixed this issue. From now the code will only override the vanilla rendering while theres darkness, not in full time.

@MerpisMe & @AViewFromTheTop also you should not put a sound effect in a rendering class, it does not do anything wrong, but its meant for rendering... well does not mean you have to change something just wanted to let you know image

it wouldn't work otherwise, the variables wouldn't sync between classes.

commented

i hopefully fixed this issue. From now the code will only override the vanilla rendering while theres darkness, not in full time.
@MerpisMe & @AViewFromTheTop also you should not put a sound effect in a rendering class, it does not do anything wrong, but its meant for rendering... well does not mean you have to change something just wanted to let you know image

it wouldn't work otherwise, the variables wouldn't sync between classes.

ik, i said i just wanted to let you know xD

commented

i hopefully fixed this issue. From now the code will only override the vanilla rendering while theres darkness, not in full time.
@MerpisMe & @AViewFromTheTop also you should not put a sound effect in a rendering class, it does not do anything wrong, but its meant for rendering... well does not mean you have to change something just wanted to let you know image

it wouldn't work otherwise, the variables wouldn't sync between classes.

ik, i said i just wanted to let you know xD

ah