Resets menu layout when using with fancymenu.
frikinjay opened this issue · 9 comments
When using a custom layout with fancymenu (2.6.2) and thonkutil (2.8.0-alpha.1+1.18). Switching menus brings back the vanilla buttons on the main menu back.
Also the branding in the bottom-left cant be hidden despite disabling it in the fancymenu settings.
Hi, dev of FancyMenu here!
Just wanted to add that this first happened after one of the last updates of ThonkUtil, it worked fine before. The modifications ThonkUtil does to the main menu probably changed in the latest(?) update, which now breaks FancyMenu.
Would be great to have an option to disable main menu modifications, this would probably fix the issues!
Thank you :)
When using a custom layout with fancymenu (2.6.2) and thonkutil (2.8.0-alpha.1+1.18). Switching menus brings back the vanilla buttons on the main menu back.
Also the branding in the bottom-left cant be hidden despite disabling it in the fancymenu settings.
reason its an alpha, alphas break a lot of things (alpha is not production ready)
will take a while to fix compatibility since using Identifier
before mixins have loaded crashes all IdentifierMixin
s as well as TextMixin
and TranslatableTextMixin
should be fixed in 13ad9a1, let me know if i screwed anything up
@Keksuccino @frikinjay download 2.8.0-alpha.2 of curseforge, i turned the feature off by default, but you never know if something will get screwed up, so see if it's fixed.
Hi! Thank you very much for the quick fix, the mentioned issues are all fixed as it seems!
But..now you've added a big red text that can't be removed ^^
I know, you want to tell people about the alpha state of the mod and that's okay, but please add a config or something, so users can turn this message off.
Thank you very much and have a great day!
//Edit: Btw: The reason why this is an issue in the alpha is that the alpha is used by many of your users already, because it seems like it mostly improves compatibility with other mods and since Goblin Traders now requires it too (as separate mod), a lot more people need to download it. Using older versions of Thonk mostly leads to other crashes with mods, that's why they use the alpha build ^^ Just wanted to clear this up a bit.
@Keksuccino will be tackled when I'm out of school
Hi, dev of FancyMenu here!
Just wanted to add that this first happened after one of the last updates of ThonkUtil, it worked fine before.
The modifications ThonkUtil does to the main menu probably changed in the latest(?) update, which now breaks FancyMenu.
Would be great to have an option to disable main menu modifications, this would probably fix the issues!
Thank you :)