Thut's Elevators

Thut's Elevators

Mods
4M Downloads

Device Linker not safe to add to Morph-o-Tool/Can't rename Device Linker

DoomRater opened this issue ยท 1 comments

commented

Issue Description:

The Device Linker does not modify its NBT stack, instead choosing to recreate it from scratch when in use, resulting in NBT data that the Morph-o-Tool uses to keep track of something being inside of a Morph-o-Tool (or Akashic Tome, if you're crazy enough) being deleted. The rest of the contents of the Morph-o-Tool will be deleted in this case.

This also has the side effect of making it impossible to rename the Device Linker, as it deletes the NBT tag that contains its name!

Steps to reproduce:

  1. Add thuttech:devicelinker to whitelist of Morph-o-Tool config list
  2. Craft a Morphing Tool with a device linker
  3. Start using the Device Linker to make an elevator
  4. Poof, no more Morph-o-Tool!

Affected Versions:

While this is noticed on 1.12.2 versions of the mod, specifically ThutCore 5.21.0 and Elevators 6.1.6, I'd be surprised if anything has changed about NBT handling of the item in later versions where Morph-o-Tool is also available. Only other note is that I'm speicifcally using Akashic Tome, but the code is over 90% the same, but since this affects renaming the item as well...

commented

Hmm, I will look into a better way to do the removal of the tag then, I was simply removing the entire tag, as that was the easiest way to do it, also for the names, the item re-names itself when linked vs unlinked.