Hardcoded localization spotted
Adaptivity opened this issue ยท 3 comments
StringHelper.java lines 33, 35, 53 ๐ and this http://i.imgur.com/1zVrwxS.jpg
Also, why not to use vanilla Tinkers Construct names? For StringHelper.java stuff.
Some more stuff:
- Weight string should have %s tag. Additionally it should have "Arrow" string because I need to modify word "Arrow" and swap it with word "Weight".
- Hardcoded "Bow" string should have %s tag too.
- tictooltips.tool.effective.durability=Effective %s should have independent "Durability" string because I need write "Durability" lowercase.
Whoops, didn't see the edit before I committed.
- Not sure how I should fix this one yet. Note, though, that the arrow string comes from
item.InfiTool.Arrow.name
. - I simply removed the "Bow" part of those strings. They weren't really necessary and they would be somewhat of a pain to make them work right with localization.
- You can just replace that whole string with your own; it doesn't have to have a
%s
in it. For example,tictooltips.tool.effective.durability=Effective durability:
would work.