[Suggestion] More customizability for the loot tables
zeroneon opened this issue · 2 comments
I think it would be great if Tide could add a little bit more customizability for Datapack makers. Here are some suggestions:
1. Add the Crates to the minecraft fishing loot table (Click me)
Example on how it could work
{
"type": "minecraft:fishing",
"pools": [
{
"bonus_rolls": 0.0,
"entries": [
{
"type": "minecraft:loot_table",
"quality": -2,
"value": "minecraft:gameplay/fishing/junk",
"weight": 10
},
{
"type": "minecraft:loot_table",
"conditions": [
{
"condition": "minecraft:entity_properties",
"entity": "this",
"predicate": {
"type_specific": {
"type": "minecraft:fishing_hook",
"in_open_water": true
}
}
}
],
"quality": 2,
"value": "minecraft:gameplay/fishing/treasure",
"weight": 5
},
{
"type": "minecraft:loot_table",
"conditions": [
{
"condition": "minecraft:entity_properties",
"entity": "this",
"predicate": {
"type_specific": {
"type": "minecraft:fishing_hook",
"in_open_water": true
}
}
}
],
"quality": 3,
"value": "tide:gameplay/fishing/crates",
"weight": 5
},
{
"type": "minecraft:loot_table",
"quality": -1,
"value": "minecraft:gameplay/fishing/fish",
"weight": 85
}
],
"rolls": 1.0
}
],
"random_sequence": "minecraft:gameplay/fishing"
}Why this suggestion?
This would let people add their own crates into the loot pool and also give a more comprehensive look at how the RNG works for datapack creators. Here is an example on how the crates.json could look:
{
"type": "minecraft:fishing",
"pools": [
{
"rolls": 1,
"entries": [
{
"type": "minecraft:item",
"weight": 5,
"name": "tide:iron_crate"
},
{
"type": "minecraft:item",
"weight": 3,
"name": "tide:golden_crate"
},
{
"type": "minecraft:item",
"weight": 1,
"name": "tide:diamond_crate"
}
]
}
]
}2. Summarize the biome-specific/conditional fish into a single json (Click me)
How it is done right now
birch.json
{
"type": "minecraft:fishing",
"pools": [
{
"bonus_rolls": 0.0,
"entries": [
{
"type": "minecraft:item",
"name": "tide:birch_trout"
}
],
"rolls": 1.0
}
]
}How it could be done
specialfish.json
{
"type": "minecraft:fishing",
"pools": [
{
"rolls": 1.0,
"entries": [
{
"type": "minecraft:item",
"weight": 30,
"name": "tide:birch_trout"
"conditions": [
{
"condition": "tide:match_biome",
"biome": {
"valid": [
"minecraft:birch_forest",
"terralith:birch_taiga",
]
}
}
]
},
{
"type": "minecraft:item",
"weight": 30,
"name": "tide:blossom_bass"
"conditions": [
{
"condition": "tide:match_biome",
"biome": {
"valid": [
"minecraft:cherry_blossom",
"terralith:blooming_plateau",
]
}
}
]
},
{
"type": "minecraft:item",
"weight": 30,
"name": "tide:thunder_trout"
"conditions": [
{
"condition": "tide:match_weather",
"weather": {
"valid": [
"rain",
"snow",
"thunder",
]
}
}
]
},
{
"type": "minecraft:item",
"weight": 30,
"name": "tide:dimensional_dripper"
"conditions": [
{
"condition": "tide:match_dimension",
"dimension": {
"valid": [
"underdark:the_underdark"
]
}
}
]
},
}
]
}Why this suggestion?
This would let datapack creators have more control over where and how certain fish spawn. Not to mention that this would also mean it'd be way easier to add biome-specific(or weather-specific/...) fish to the mod in the future by simply plopping them in here. One of the biggest changes that this would allow is also giving datapack creators the opportunity to change the weight of the biome-specific fish.
This could even apply to the first suggestion to allow biome-specific crates!
My third suggestion doesn't have anything to do with customization but something to maybe add to another suggestion that someone has made - the attachments. Since they will soon be directly added to the fishing rods - maybe you could do the same with bait? Attach it to the rod on the fisherman workbench where they would automatically be consumed if a player uses that rod?
Anyway, thanks for your hard work! Really love it and don't sweat it if you don't like these ideas. Just wanted to give perspective as a modpack/datapack creator what I would love to see from this mod :)
I think this would be great! The mod’s fishing loot system is old and buggy and could definitely use a rework.
Thanks for the idea :)