Incompatibility with BCLib, Reforged button on anvil doesn't work

Question

Incompatibility with BCLib, Reforged button on anvil doesn't work

ConqAra opened this issue 3 years ago · 13 comments

ConqAra commented 3 years ago

I'm trying to click on the reforge button in the anvil menu and it just doesn't work.

Leonelecg · Answer 1 · 2022-07-02T14:59:43.000Z

I have the same problem, and I found out why, I guess it's an incompatibility with BCLib

Here is the BCLib curseforge link: https://www.curseforge.com/minecraft/mc-mods/bclib

ConqAra · Answer 2 · 2022-06-25T04:46:54.000Z

May have to do something with a mod incompatibility? I can send my log but i dont see an error for this.

Log: https://paste.ee/p/3InhH

Globox1997 · Answer 3 · 2022-06-27T10:20:51.000Z

Mh this is pretty bad, the good thing is you only have quadrillion mods installed xD
I have no idea what could cause this issue, maybe a screen editing mod

Leonelecg · Answer 4 · 2022-07-19T13:21:36.000Z

I'm pretty sure BCLib is what's causing the error, maybe some kind of incompatibility

jklw10 · Answer 5 · 2022-07-15T12:00:05.000Z

Can confirm, button doesn't work and I do have BCLib but I cannot know if that's the one mod that causes this. I'm unsure because i don't know if bclib itself changes the anvil menu in any way?

Globox1997 · Answer 6 · 2022-07-16T09:45:44.000Z

If you guys can narrow down the incompatibility, that would be super helpful :)
I will look into it when I have time for modding again

jklw10 · Answer 7 · 2022-07-22T03:48:08.000Z

I think a good temporary fix would be to add a keybind to switch to reforge screen...

Globox1997 · Answer 8 · 2022-07-23T09:10:11.000Z

Pretty sure this is the issue: https://github.com/paulevsGitch/BCLib/blob/main/src/main/java/ru/bclib/mixin/common/AnvilMenuMixin.java#L180
BCLib overrides the onclick method (different mappings) so the tiered injection won't get used
Can't make it compatible from my side, except adding a keybind which sucks

jklw10 · Answer 9 · 2022-07-23T09:49:32.000Z

hmm i assume you'll open an issue for it then. or just make a pull request with it being an injection instead of override.

Globox1997 · Answer 10 · 2022-07-26T12:11:13.000Z

I assume you will open an issue :)

itsdinkd · Answer 11 · 2022-07-27T05:43:47.000Z

You guys are lazy! I'll open the issue.

itsdinkd · Answer 12 · 2022-07-27T16:05:15.000Z

I assume you will open an issue :)

Please respond to the developer in the ticket I opened on their github. It's linked here

kleonaut · Answer 13 · 2022-08-11T00:51:28.000Z

Please address this

Any plans of applying these fixes to 1.18.2?

Yes, but there is no ETA as it currently has low priority. As far as I can tell, TieredZ can just change the mixing priority to override ours. Which should be absolutely fine. Our mixing is there to show UI in case there are multiple recipes for the same list of ingredients. I think that is not uses in 1.18.2 anyway.

quiqueck/BCLib#28

Share to