Bows dealing random damage between 0-20 no matter tier
slovinsqui opened this issue · 18 comments
I saw someone else having this problem in the issues page, closed because it got tagged with a won´t fix in another mod´s github saying it must be an incompatibility
I decided to remove the rest of the mods in my modpack to test it myself, as a result the inconsistencies still happen, only having two mods
some times there is no damage at all, but there is knockback and damage flashing
mods: one that indicates damage inflicted and a datapack displaying the mobs health
https://www.planetminecraft.com/data-pack/splatus-vanilla-refresh-quality-of-life/
https://www.curseforge.com/minecraft/mc-mods/damage-indicator-mod
maybe it´s not about incompatibility (or intentional??) but i dunno, im not a coder
oh, well I get 20 dmg crits with non tiered bows even with no armor equiped, that´s what got me confused in the first place
Is that intented?
Should be fixed with 55c2830
I ran a quick test and it seems that the non damaging shot is gone, but the 20 damage to bows with no current tier is still there, I don't have time to test this at the moment but i'll check it out later
yeah, the 0 damage thing is gone, but the normal bows still reach 19 damage (without enchantments)
armor should not give crit chance at all but the bow for example can give crit chance
wait, so crits can still happen regardless of the crit chance stat? I thought non tiered bows had no crits at all, i mean, that´s what I understood lol
is there a way to tweak crit chances and critical damage?
btw sorry if Im being too insistent lol
If bows have no tier, armor can give crit chance too
Without crit chance, it doesn't affect the vanilla mechanic
Can confirm that this mod alone makes standard bows (bows pulled from the creative inventory without any tier) more OP
Non-tiered bow damage without mod installed: 8-10
Non-tiered bow damage with mod installed: 12-19
I suspect the issue lies here, you're modifying the damage the bow outputs to be the regular damage plus what crit damage would be
https://github.com/Globox1997/tiered/blob/1.20/src/main/java/draylar/tiered/mixin/BowItemMixin.java
persistentProjectileEntity.setDamage(
persistentProjectileEntity.getDamage() + AttributeHelper.getExtraCritDamage((PlayerEntity) persistentProjectileEntity.getOwner(), (float) persistentProjectileEntity.getDamage()));
}
the getExtraCritDamage already returns oldDamage, so by adding it TO persistentProjectileEntity.getDamage() you're effectively doubling your damage for bows
I compiled a version without persistentProjectileEntity.getDamage() and it seems to work better
Thank you @snoandpetals
fixed with da0d2b7