Tinker I/O

Tinker I/O

13M Downloads

Smart Output Lag

cjm721 opened this issue ยท 12 comments

commented

Been trying to fix some lag on my server and one of the major causes is tinker_io.TileEntity.SOTileEntity

It appears to be because of the cost of the registry lookups in base TC but that would suggest that TC's tables should be doing the same thing but they don't take nearly as much.

image

commented

Hello,
We've had the same kind of issue with the smart output causing lag on our server. After some testing, it occurs when there is some liquid in it but it can't do anything with it, like the equivalent of liquid of a few nuggets with an ingot cast for example.
Version of Tinker I/O : tinker_io-1.12-release 2.5.6e.jar
Forge : 1.12.2 14.23.1.2587
modpack : all the mods 3 (version 5.7b)

If you'd rather have me open another issue I can but it seems to be same problem as cjm721.

Jin

commented

and It also lags a lot while being used actually.

commented

@GemOfEvan 's code can solve the problem. I will use the code in 1.10.2 and 1.12 to fix this issue.

commented

Having this same issue, profiled with Yourkit.

commented

The problem have been solved in Tinker I/O release 2.6.0.
Thanks for report!

commented

@kenijey it's a java profiler, it keeps track of how often and how long methods take to execute and can as such be used to detect bottlenecks in applications.

commented

hey @cjm721 sorry ah, can you explain what program do you use in that screenshot that shows lags in the issue pls? thanks

commented

it seems very useful and wanna use it but don't know its name or anything it has.

commented

Hello,
after a few tests, I found one scenario when the Smart Output generates lag (uses about 30 % time tick)
If you have some liquid in it but no cast, it ticks a lot.

Tinker I/O version : tinker_io-1.12.2-release 2.6.0a
Forge : 14.23.2.2617
Mc version : 1.12.2
Modpack : All the mods 3

commented

Okay, I'll try to fix it. Thanks for report.

commented

@cjm721 Could you tell me which software you are using to observe the performance of server? I want to test on my own computer. Thanks!

commented

jvisualvm mostly. It is included with orcale JDK.