Tinkers Construct

Tinkers Construct

160M Downloads

smeltery visual bug with seared glass

gamerpudding opened this issue · 22 comments

commented

my smeltery is 3x3 on the inside and 10 blocks down. the seared glass works at 8 blocks deep but if you look lower then that the fluids disappear but the items/fluids are still in the smeltery and the smeltery still works.

version; stoneblock 2 (1.16.1)
minecraft version: (1.12.2)
forge version:(14.23.5.2846)
Tinkers Construct:(2.12.0.157)

commented

Screenshot showing your issue? It explains visual bugs a lot better than words.

Also, fix your versions, you entirely missed Tinkers Construct and there is no Tinkers Construct for 1.14.4

commented
commented

Did you attach the screenshots to your email? That does not show up on Github

commented
commented

Yes, those do not show up on Github, I have no way to view them. Upload them to a site such as imgur and link them here.

commented
commented

2019-11-04_00 35 30
2019-11-04_00 33 37
2019-11-04_00 33 23
2019-11-04_00 33 09
2019-11-04_00 32 51
2019-11-04_00 32 39
2019-11-04_00 32 27

commented

This might be related to how minecraft decides what to render. Does moving the smeltery controller lower/higher have an impact?

commented
commented

Minecraft only renders blocks that it deems "visible". Smeltery fluids are drawn by the controller. It has a pretty big area that counts as "visible", but it can't possibly cover everything.

commented

Any chance that area could be set dynamically to the Smeltery's current internal size? if so, that should fix this, no?

commented

It is. That doesn't mean minecraft renders infinite range though.

commented

I'd assume it would render the exact same range of blocks the player can see, but I honestly know nothing of MineCraft's render code.

commented

When minecraft decides that the smeltery (which is out of vision) should stop rendering (which causes the fluids to stop rendering), even though the controller - theoretically - has the same "rendering visibility" to minecraft as the whole smeltery structure.

commented

Wait but... if the controller attempts to render fluids contained anywhere inside the smeltery structure and Minecraft should render the full range a player can see in, what's stopping the fluids from rendering? I'm confused ^^'' And sorry for asking so many questions.

commented

But... in the case described by this issue, isn't the smeltery in view? Therefore, shouldn't the fluids be rendering? As far as I can tell, his smeltery isn't particularly big.

commented

smeltery = controller

commented
commented

My previous experiments with minecraft's notion of what's in view suggest it always tended to anchor the bottom of the render volume to the 'key' part of the total volume. See: anything involving vanilla armor stands when the base of the armor stand isn't in view.

I know tinkers' construct attempts to compensate for that (based on above link to the source code), but it wouldn't surprise me to learn that with a sufficiently tall smeltery that had the controller on the top layer, it would be attempting to render the fluids at the bottom even while you were looking over the top of the smeltery structure (such that the controller was just barely below your line of vision)

commented

On whimsy, I attempted to reproduce this using TConstruct-1.12.2-2.13.0.171.jar and I cannot actually seem to reproduce the problem.

@gamerpudding what version are you running? Your opening post still claims minecraft 1.14 (which is obviously wrong) and doesn't mention what version of tinkers' construct you have, even though knightminer requested you provide that information.

screenshots:
2019-11-22_15 38 28

2019-11-22_15 38 39

  • edit to correct which dev requested versions, because apparently I can forget names when they scroll off the screen.
commented

I'm going to close this, since the issue seems to have been worked around at least, and is not really solvable on our side anyway.