Tinkers Construct

Tinkers Construct

160M Downloads

Smeltery burn effect does not test for dimension.

funnbot opened this issue ยท 4 comments

commented

Issue description:
The burning effect from standing in the smeltery does not test for dimension, so if the smeltery is chunk loaded, and the player is within the bounding box and same coordinates, but in a different dimension, the player will still be burned.

The getWorld().getEntitiesWithinAABB function used in the interactWithEntity test should return entities only within that dimension/world ID, I do not know if other mods, or other things are having this same problem, it might be an issue outside of TiC.

Versions:

  • Minecraft: 1.12.2
  • Forge: 14.23.5.2846
  • Mantle: 1.3.3.55
  • Tinkers Construct: 1.12.2-2.12.0.157
commented

A world is a dimension. That method only returns entities inside that dimension. Sounds like you got damaged by something you didn't know the source of?

commented

I have tested this a few times and I can confirm it is only within the coordinates of the smeltery in the other dimension, and only happens when there is something melted in the smeltery (because if it is empty it will not burn you).

commented

Can you reproduce with a minimal mod list? Any of your mods could be doing unsafe things in the world.

As boni said, each world is a separate dimension, so there is no reason it should fetch entities from another dimension unless some mod has damaged dimensional travel. Also worth mentioning how you reached the other dimension, maybe they are not fully removing the player from the overworld.

commented

Closing for lack of response, the method we use does not work cross dimensionally unless some mod is seriously breaking things. Possibly a broken dimensional teleport