Tinkers Construct

Tinkers Construct

160M Downloads

With Quark installed, pushing seared tanks with pistons sometimes causes tank to behave as if empty

TheDeviantCrafter opened this issue ยท 7 comments

commented

Issue description:

Quark adds the ability to push tile entities with pistons. Pushing a seared tank sometimes causes the smeltery to think the tank is empty. The UI will show no lava, and it will refuse to melt items.

The tank will render as empty when the bug occurs. However, The One Probe will show the tank as full. If the tank is mined, the item will show lava in the tooltip.

Breaking and replacing the tank will fix the issue. No lava is ever lost.

Replication steps:

  1. Install Quark and Tinkers
  2. Build a valid smeltery
  3. Fill the seared tank with lava
  4. Use a sticky piston to pull the seared tank away, causing the multiblock to unform
  5. Use a sticky piston to push the seared tank back, reforming the smeltery
  6. About 75% of the time, the

Versions:

  • Minecraft: 1.16.5
  • Forge: 36.1.2
  • Mantle: 1.6.92
  • Tinkers Construct: 3.0.2.96
  • Quark: r2.4.310

Can it be reproduced with just Tinkers Construct? If not, list the other mods required to reproduce the issue.

This bug requires Quark to be installed. Quark allows tile entities to be pushed using pistons.

commented

Closing as this is likely fixed

commented

Does this still happen on the latest alpha? I changed some of the logic with how seared tanks sync their fluids

commented

Sounds like quark is missing one of the proper events on moving a tile entity so the TE knows its moved. There is a packet vanilla sends when a block is first placed in the world to write the original TE contents, if that packet is missing the tank's fluid will be invisible. You should be able to drain a bit and it will update the renderer.

All that to say, report this bug to quark, they are failing to send vanilla packets we need

commented

The smeltery also doesn't recognize the lava within the tank. Is that caused by the same missing packet or is it a separate issue?

commented

Thats probably caused by the structure NBT being out of sync. The controller does not believe the tank is part of the structure because you moved it illegally. Place another block to extend the structure.

I'm half inclined to just block all piston movement, but its nice to have when there is no smeltery involved.

commented

I was using a block swapper to switch from molten blaze to lava and back on command. That use case seems useful enough to be worth persevering. Pipes or fake players can probably do the same thing depending on the pack.

commented

The problem is with how Quark places blocks. It does not place the tank there, it moves it. And the smeltery does not expect to be moved, so things get out of sync.