Minecraft Version

1.16.5

Forge Version

36.1.32

Mantle Version

1.6.115

Tinkers' Construct Version

3.1.0.231

Describe your issue

Minor issue, found this while trying to reproduce a different issue. When clicking on drain or tank with a full bucket and the player has no other empty bucket in inventory, the bucket is "duped" as a new empty bucket while also [correctly, for creative mode] leaving the full bucket in inventory]

Crash Report

No response

Reproduced with only Tinkers' Construct?

Yes

Other mods required

No response

• Confirm you are not using performance enhancers, such as optifine
• Confirm you have checked the roadmap, what's new, and the FAQ for your issue

So, not sure if this is worth fixing. The current behavior is consistent with filling a bucket from a fluid in world, while being inconsistent with both emptying buckets and interacting with cauldrons.

I can make it fully consistent with cauldrons, having no containers in creative. However, that also means that emptying the drain would not give you a filled bucket. While this is consist with cauldrons, I am not sure its desirable behavior. Making it just give you filled buckets and not empty is harder however.

Open for suggestions.

The logic I use is a vanilla method in "DrinkHelper", which avoids giving you the container item if you already have a container and are in creative. Its the behavior I would call more normal compared to performing no action with the items, so if you see anywhere not doing that in creative that is a bug without a doubt.

As I said, the main case I question is whether its worth giving you an empty bucket/copper can. I think giving you filled buckets/copper cans is quite useful.

---

copper cans, clay buckets [ceramics], and presumably other modded single-shot container items that store their fluid contents as NBT do not exhibit the same behavior as buckets - this is confusing from an end-user perspective, even though I think I understand the technical reason why it is this way.

Can you clarify? Is this in regards to the seared tanks/drains or in general? I would assume those two both follow the same behavior as buckets, if not there is a bug with a missing itemstack copy.

1. I guess I don't really have an objection to the current behavior - it just caught me by surprise since no other mod does that... but thinking about it more, it's something that's always annoyed me about other mods
2. doing this with a tank has the same behavior that everything else has for buckets - the smeltery is emptied and the tank remains empty, or vice versa - this is also annoying some times, though I can't argue that it wouldn't be useful at other times.
3. copper cans, clay buckets [ceramics], and presumably other modded single-shot container items that store their fluid contents as NBT do not exhibit the same behavior as buckets - this is confusing from an end-user perspective, even though I think I understand the technical reason why it is this way.

I will admit that I had somehow wrongly got the impression that it would keep giving me more empty buckets, filling my inventory with them, but now that I look at it again it seems I imagined it. If not for that, I probably wouldn't have reported the issue in the first place.