Seared drain output fails if smeltery is deconstructed while the drain is outputting
luckyu19 opened this issue ยท 6 comments
Minecraft Version
1.16.5
Forge Version
36.2.2
Mantle Version
1.16.5-1.6.123
Tinkers' Construct Version
1.16.5-3.1.2.265
Describe your issue
Steps to reproduce:
- Get fluid out of the smeltery.
- While the fluid is flowing out of the smeltery, break the smeltery.
- Rebuild the smeltery. The output function will fail (input will still works).
- Replacing the seared drain will fix the issue.
Not sure if it can be/should be fixed.
Doesn't happen with chute or the input function.
Crash Report
No response
Reproduced with only Tinkers' Construct?
Yes
Other mods required
No response
- Confirm you have checked the roadmap, what's new, and the FAQ for your issue
- Confirm you are not using performance enhancers, such as optifine
@StaticPH I think you misunderstood the issue. Seems there is a problem when the smeltery rebuilds, it does not trigger block updates from the drain, which prevents the faucet from clearing its cache, so the faucet believes there is no tank. Easy enough fix luckily.
Ah. I had wondered why they'd been unsure if the behavior was intended, but I think I understand now. Communication is hard. Personally, I'm of the opinion that pouring (from faucets, specifically) should not resume when the smeltery multiblock reforms after being broken (only after being added to, which I think I remember already being the case). That might just be me though.
In any case, am I to assume this issue can be closed then?
I think you are still misunderstanding the issue. The problem is not that the faucet does not resume pouring. The problem is the faucet cannot pour after breaking the smeltery. Interacting with the faucet does nothing after breaking the structure. So no, this cannot be closed yet, as it was a bug which is not in a released build yet.
If I understand correctly, you're breaking the smeltery controller. If you are, then this behavior makes sense, as the smeltery fluid data resides in the smeltery controller. If the controller is broken, the drain clearly has no way to continue pouring fluid out, because there simply isn't any.
Now, that's assuming that you were breaking the smeltery controller specifically, or some smeltery block on the same level as or below the drain. I don't believe that breaking a smeltery block above the drain should have any effect upon the drain, though.
If I understand correctly, you're breaking the smeltery controller. If you are, then this behavior makes sense, as the smeltery fluid data resides in the smeltery controller. If the controller is broken, the drain clearly has no way to continue pouring fluid out, because there simply isn't any.
Now, that's assuming that you were breaking the smeltery controller specifically, or some smeltery block on the same level as or below the drain. I don't believe that breaking a smeltery block above the drain should have any effect upon the drain, though.
I tested it by breaking one of the seared stones at the level of smeltery controller.