Tinkers Construct

Tinkers Construct

160M Downloads

PvP attacks with secondary damages (e.g. Piercing) prevent knockback on the player attacked.

Insane96 opened this issue ยท 1 comments

commented

Minecraft Version

1.18.2

Forge Version

40.1.51

Mantle Version

1.9.28

Tinkers' Construct Version

3.5.1.32

Describe your issue

Attacking another player with a weapon that deals multiple damages (e.g. Piercing) will prevent the player from getting knockbacked most of the times.

3b7cdf6fa2e8516c0421a69a487d8dee.mp4

This seems to be a problem with https://github.com/SlimeKnights/TinkersConstruct/blob/3.5.1.31/src/main/java/slimeknights/tconstruct/library/tools/helper/ToolAttackUtil.java#L332
As commenting this line makes the knockback work properly again.

Crash Report

No response

Other mods

None

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

I did not search

commented

Fixed in 3.4.2.40, hopefully. Any PvP related bugs tend to be whack-a-mole so will be interesting to see what new bug was caused by the fix.