Tinkers Construct

Tinkers Construct

160M Downloads

Crafting daggers and then salvaging can dupe materials

BitBlitObviMormon opened this issue ยท 6 comments

commented

Minecraft Version

1.18.2

Forge Version

40.2.0

Mantle Version

1.9.43

Tinkers' Construct Version

3.6.3.111

Describe your issue

The 3.6.3.111 version of Tinkers Construct crafts 2 daggers instead of one when crafted, however the behavior of the part builder has not been changed to reduce how much can be salvaged from a dagger. Therefore two parts can be crafted into a pair of daggers and then salvaged into four parts (2 small blades and 2 tool handles). This can be exploited to create infinite resources so long as you have one of a resource and two of another resource. There is a similar bug where you can dupe weapon modifiers (as reported in #5093).

Possible fixes

  • Make daggers always return a handle or some scrap when salvaging (Returning a blade can still dupe metal materials)
  • Make daggers create only one dagger on creation (a 1-cost dagger blade part could help reduce crafting cost in this instance)

Crash Report

No response

Other mods

Mantle

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ

commented

Duplicate of #5093

commented

Ah, misread as "salvage" is a term for modifiers typically, but still, the issue you linked mentioned in the comments I fixed both, see be7b23a

commented

Already fixed for next release. Leaving open until build has been released. Same fix as the issue you mentioned.

commented

"salvage" is a term for modifiers typically

What term do you use to refer to getting parts back from weapons then?

commented

Recycling

commented

Fixed in 3.6.4.113