Tinkers Construct

Tinkers Construct

164M Downloads

Potion buckets having weird interaction with Create

Ashley123477 opened this issue ยท 3 comments

commented

Minecraft Version

1.18.2

Forge Version

40.2.9

Mantle Version

Mantle-1.18.2-1.9.45

Tinkers' Construct Version

TConstruct-1.18.2-3.6.4.113

Describe your issue

So i dont really believe this is an issue but could be a little confusing for people using Create and Tinkers together.

The issue exactly is to do with how Tinkers manages potions, essentially making them look like buckets, i believe which they are textured bottles?

Due to this JEI shows some weird behaviour with create.

See images for example
2023-07-08_16 05 26
2023-07-08_16 00 06

In the first image. What looks like a bucket is getting drained a returning a glass bottle
In the second image it is showing filling a glass bottle with potion to return a bucket with potion

Crash Report

None

Other mods

create-1.18.2-0.5.1.b

Tried reproducing with just Tinkers?

No

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues

commented

Yeah, nothing to do with Tinkers. This is just Create not making the input and output sizes match, you probably would find other examples if you dug enough. That, or its a bug in Create as they assume all potion items hold 250mb of potion (which is simply not true)

Tinkers is not retexturing potion bottles anywhere. Potion buckets are a distinct item that holds 1000mb of potion. It acts as a bucket like the milk bucket, drink it for effects.

I recommend reporting this issue to create, see what they have to say. Just know they are done with 1.18.2 for the most part, but maybe they can fix it for later versions.

commented

I'm going to go ahead and close this issue given its a bug in Create that we cannot fix caused by a faulty check on their side. Seems they fixed it with a hacky fix on 1.20.1, ignoring my suggestion for a clean fix (their hacky fix is hardcoding to buckets while the clean fix is just checking for a fluid handler).

Anyways, nothing more to do on this issue.