Book link doesn't work correctly
koh-gh opened this issue · 4 comments
Minecraft Version
1.18.2
Forge Version
40.2.17
Mantle Version
1.9.50
Tinkers' Construct Version
3.7.1.155
Describe your issue
For upgrades that have multiple types with the same name (e.g. Pierce, Fiery, Freezing), pressing any link will jump to the same page. Lightspeed jumps to the correct page, so I think a similar fix is needed.
The targets are Puny Smelting and Encyclopedia.
Crash Report
No response
Other mods
JEI
Jade
Tried reproducing with just Tinkers?
Yes
Performance Enchancers
None of the above
Searched for known issues?
Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ, Checked the in game books
Light speed is actually two modifiers. The rest are all a single one. Light speed needs to get merged eventually but has not yet for a few internal reasons
For example, pierce has different effects at melee and at ranged, and there has two table of contents and two pages. But pressing any link will jump to the same page.
I think this will not be integrated as I feel the effect was intentionally changed.
Yeah, I understand the issue, was just being clear about why lightspeed works.
Fixing this will probably mess with the translation strings in the language.lang files but should be doable.