Tinkers Construct

Tinkers Construct

163M Downloads

Tank modifier draws excessive fluid while interacting with fluid tanks in other mods

EtSH-C2H6S opened this issue ยท 5 comments

commented

Minecraft Version

1.19.2

Forge Version

43.4.0

Mantle Version

1.10.36

Tinkers' Construct Version

3.8.3.39

Describe your issue

When interacting with fluid tanks in Mekanism mod using tools with tank modifier, the fluid will be totally drained EVEN IF the tank holds more fluid than fluid capacity of the tool. Same situation also happens with fluid tanks in Industrial Foregoing.

2024-09-04.14-21-06.1.mp4

Crash Report

No response

Other mods

Mekanism -10.3.9
Just Enough Items -11.6.0.1019
TConJEI -1.2.1

Tried reproducing with just Tinkers?

No

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues, Searched closed issues, Checked the FAQ, Checked the in game books

commented

Yeah, I need more context on this one. The tools work perfectly fine with our tanks, and its the tank that implements interaction behavior on right click.

Do you also have this issue with seared tanks right clicking on the other mod's fluid tank? Also try with copper cans.

commented

Yeah, I need more context on this one. The tools work perfectly fine with our tanks, and its the tank that implements interaction behavior on right click.

Do you also have this issue with seared tanks right clicking on the other mod's fluid tank? Also try with copper cans.

No, seared/scorched tank and copper cans works just fine, the issue seemed to only happen with modifiable items.
Also, this issue won't occur when interacting with fluid cell from Thermal Series.

commented

Does this issue happen on 1.18?

Does it happen with any mods other than Melanism? E.g. create or immersive engineering

commented

Okay, if the issue also existed on 1.18 that rules out the recent refactors as causing this. I am going to bet since it only happens with a small subset of mods that the issue is actually on Mekanism and Industrial Foregoing's sides, they are likely not doing enough safety checks for fluid transfer. I recommend crossposting the issue there and linking it here. If I am doing something wrong on my side, somehow it works in basically every other mod.

For some additional context for the crosspost, Tinker tools with tanks support variable amounts of fluid with a fixed max capacity, though that max capacity is determined by NBT. The tools also don't always have a tank, some NBT variants will be listed as having 0 tanks.

commented

Does this issue happen on 1.18?

Does it happen with any mods other than Melanism? E.g. create or immersive engineering

Now I've tested tanks from create , immersive engineering , pneumaticcraft , functional storage and also tested transfering fluid from AE2 terminal, and the issue didn't occur.It only happens with tanks in mekanism and industrial foregoing. Also this issue does happens on 1.18 (with tcon ver. 3.6.4.113).