Tinkers Construct

Tinkers Construct

165M Downloads

[1.20.1] TC makes KubeJS fail on load

carbonatek opened this issue ยท 4 comments

commented

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.0

Mantle Version

1.11.28

Tinkers' Construct Version

3.9.0.6

Describe your issue

I know that using large packs is probably not supported with alpha versions (in which case, I apologize, but I wanted to try it out in a more realistic scenario rather than isolated) but installing TC into my private modpack causes KubeJS to no longer load recipes.
Reloading KubeJS using /reload works though, so there's just something wrong with the initial load. Modifying any recipe, as seen in the example I've provided in "Other mods", makes KJS fail to load w/ TC.

Crash Report

https://gist.github.com/carbonatek/dcf59b871825b6496bcfbf3036cdb02a

Other mods

TC same ver, Mantle same ver, JEI 15.20.0.105 (same version), KubeJS 2001.6.5-build.16, Architectury 9.2.14, Rhino 2001.2.3-build.6.
in the testing instance isolated from the modpack, a test script in kubejs/server_scripts/example.js:

ServerEvents.recipes(event => {
     event.remove({output: 'minecraft:blaze_powder'})
})

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues

commented

You can disable KubeJS running recipe stuff in parallel by setting allowAsyncStreams to false in kubejs/config/common.properties. That should resolve this.

commented

Thanks for the temporary solution :-)

commented

Seems that not everything in Mantle's tag preference system is fully multithread safe. Most of it is but I missed one spot. Should be an easy enough fix.