V-Minus breaks the mod because they mixin where they shouldn't mixin
ModernGamingWorld opened this issue ยท 6 comments
Minecraft Version
1.20.1
Modloader
Forge
Modloader Version
47.3.22
Mantle Version
1.20.1-1.11.28
Tinkers' Construct Version
1.20.1-3.9.0.6
Describe your issue
I added Tinker's to my new modpack version for 1.20.1, and it crashed. I have provided the crash log and logs to help figure this out
crash-2025-01-01_16.15.20-client.txt
Crash Report
No response
Other mods
Well I can provide this, as I don't know how else to get the mod list for you
Fun-Filled Adventure-1.0.0.zip
Tried reproducing with just Tinkers?
Yes
Performance Enchancers
Other (specify under other mods)
Searched for known issues?
Searched open issues
You claim you reproduced this with just tinkers in the issue forum, can you upload the log with only tinkers in it?
Also, your log says you have diagonal fences. Diagonal fence mods are known to cause issues with mods that add custom glass panes like Tinkers, so you really should remove that if you want tinkers.
I doubt its Diagonal fences as I am using it in my other pack with Tinkers on 1.20.1 with no issues
at TRANSFORMER/[email protected]/net.minecraftforge.registries.ForgeRegistry.getDelegateOrThrow(ForgeRegistry.java:1648)
at TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:148)
at TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:143)
at TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.<init>(ItemStack.java:127)
at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.handler$dmp000$vminus$getFoodProperties(Item.java:6047)
at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.m_41473_(Item.java:362)
at TRANSFORMER/[email protected]/slimeknights.mantle.item.EdibleItem.<init>(EdibleItem.java:26)
at TRANSFORMER/[email protected]/slimeknights.mantle.item.EdibleItem.<init>(EdibleItem.java:21)
Here is your problem. Someone is writing a mixin into getFoodProperties and constructing an item stack from it. No idea who vminus is but you will have a better idea. No idea why they have a mixin there.
We don't need to call that method in our constructor of the item, but all that method should be doing is returning a value from a vanilla field; forge has a stack sensitive constructor they can use for their mixin nonsense. So figure out who vminus is and crosspost this issue to them.
VMinus' issue tracker: https://github.com/lixxir/VMinus/issues