Issue present when loading Creative inventory on a modpack
Closed this issue ยท 7 comments
Minecraft Version
1.20.1
Modloader
Forge
Modloader Version
47.3.5
Mantle Version
1.11.36
Tinkers' Construct Version
3.9.1.19
Describe your issue
Causes issues when loading inventory (a Java Exception error) when AnitBlocksRechiseled v0.4.4 is present/included within a modpack.
The issue was not present before adding Tinker's Construct. Logs lead to the belief that AntiBlocksRechiseled is the culprit. Disabling AntiBlocksRechiseled resolved the issue and it no longer crashes when opening the Creative inventory.
It is probably not a common issue, but the modpack that I made has a lot of different mods and this one was a feature that was previously added to the modpack. Modpack is public, so a modpack link will be posted, because there are many mods in the modpack and adding a full list would be expansive.
Here is the link to the issue opened on AntiBlocksRechiseled bug reports page: manmaed/AntiBlocksReChiseled#15
Crash Report
Other mods
https://www.curseforge.com/minecraft/modpacks/fanciful-fanciness/files/6111940/dependencies
Tried reproducing with just Tinkers?
Yes
Performance Enchancers
Rubidium/Embeddium
Searched for known issues?
Checked the FAQ
Provide the full crash report in a paste, not in the text body please. You cut off important parts of it.
Also, if you believe this only happens with tinkers and that other mod, then report it to them as well and link the issue here.
Provide the full crash report in a paste, not in the text body please. You cut off important parts of it.
Also, if you believe this only happens with tinkers and that other mod, then report it to them as well and link the issue here.
I will upload to a pastebin. My apologies.
EDIT: The crash log is now on a pastebin. The link is located under the "Crash Report" section of the body text.
I have also submitted a bug report with AntiBlocksRechiseled.
Crash says its a bug with net.manmaed.antiblocksrechiseled.AntiBlocksReChiseled
. IForgeItem#getCreatorModId
is annotated as @Nullable
, so they should be validating the return to ensure its not null.
Crash says its a bug with
net.manmaed.antiblocksrechiseled.AntiBlocksReChiseled
.IForgeItem#getCreatorModId
is annotated as@Nullable
, so they should be validating the return to ensure its not null.
I will have to wait and see what they say
doing:
String creatorModId = item.getCreatorModId(item.getDefaultInstance());
then logging:
ResourceLocation registryName = ForgeRegistries.ITEMS.getKey(item);
LOGGER.warn("Item '{}' has a null creator mod ID", registryName);
outputs: Item 'tconstruct:modifier_crystal' has a null creator mod ID
doing: String creatorModId = item.getCreatorModId(item.getDefaultInstance()); then logging: ResourceLocation registryName = ForgeRegistries.ITEMS.getKey(item); LOGGER.warn("Item '{}' has a null creator mod ID", registryName); outputs: Item 'tconstruct:modifier_crystal' has a null creator mod ID
It's not a bug. The documentation for the method says null is a valid return to indicate "no mod ID", which is the case for a crystal with broken or missing NBT