Tinkers Construct

Tinkers Construct

170M Downloads

Crash with crossbows

Closed this issue ยท 5 comments

commented

Minecraft Version

1.20.1

Modloader

NeoForge

Modloader Version

47.4.0

Mantle Version

1.11.55

Tinkers' Construct Version

3.10.0.67

Describe your issue

Clicking on a Crowwbow crashses client

Steps to reproduce

Click on a crossbow

Crash Report

https://mclo.gs/1SPWA8i

Can you reproduce with just Tinkers?

I have not tried

Performance Enchancers

Rubidium/Embeddium

Other mods

No response

Searched for known issues?

Searched open issues

commented

Looks to be an addon problem, though its something I can likely patch to make not break the addon. I learned recently that a certain change I made to the API was not in fact binary compatible with addons, though I did not expect anyone to be using those hooks.

Looks like Tinkers Thinking is the addon affected by this, so a cross post to their repo would work. Fix on their side is as simple as recompiling the mod against newer tinkers. Fix on my side is readding the method with old signature.

commented

Just want to follow up to note I have a release planned for the next couple of days in which I should be able to fix this issue on Tinkers' side. Though its important that Tinkers' Thinking does not push an fix for this issue as well or the two fixes will cancel out causing it to break.

There is an alternative but less desirable fix I can apply if Tinkers' Thinking releases a new build before then, so putting off pushing the commit that fixes this until right before I am ready to push the release.

commented

I did not put anything on their github yet, so I will not do that

commented

Seems like Tinkers' Thinking just updated. So, check if this is still an issue.

If its not it might be best to just take no action unless another addon is affect; its a pretty unlikely hook to be called.

commented

Fixed in 3.10.1.76. applied the fix variant that works with both mods compiled against 3.9.x and 3.10.0.