Units are displayed inconsistently for things that do not use ingots
Closed this issue ยท 4 comments
Minecraft Version
1.20.1
Modloader
Forge
Modloader Version
47.4.2
Mantle Version
1.11.61
Tinkers' Construct Version
3.10.1.76
Describe your issue
Repair kits for things like string and ender use units of ingots.
(note I have modified the config to make them repair 3 instead of 2)
Additionally for part building in JEI the material cost for string displays as 1/4 the required item count amount due to 1 string being worth 0.25 material.
For someone not used to this, it reads as 'costs 2 string'.
Note this is also an issue for things like wood where logs or planks can be used, it would be better to display this as stack count on the input items so that different items can have different counts as they get cycled through.
Note this is not a comment on the typo thread due to it being quite a bit more complex than a lang file change.
Steps to reproduce
See screenshots
Crash Report
No response
Can you reproduce with just Tinkers?
I have not tried
Performance Enchancers
Rubidium/Embeddium
Other mods
see notes on hat in previous issues
Searched for known issues?
Checked pinned issues, Searched open issues, Searched closed issues
I don't understand the first issue. Repair kits say it repairs the equivalent of ingots. There is not another term for "1 unit of the thing" that is not confusing.
As far as the second issue, its not showing material costs in the stack sizes. Its just showing single items. I'll have to look at that code again to see how feasible it is to include stack sizes; IIRC there is a cache there which may make that impractical.
Can the repair kits not change their tooltip depending on the material?
So cobblestone/obsidian would say 'repairs the equiv. of 3 blocks', ender pearls would say 'repairs the equiv. of 3 pearls' ect.
Materials don't have unit names. It be a breaking change to introduce that now unless I go the hacky route of optional translations (which past experience has told me often breaks with translations).
Fluids have unit names but not all materials are fluids.
Maybe there is something that can be done with material tags. But its a huge effort for a single tooltip.