Tinkers Construct

Tinkers Construct

170M Downloads

Question: How do I define the amount of molten fluid in an ingot

Closed this issue · 6 comments

commented

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

Forge 47.3.10

Mantle Version

Mantle-1.20.1-1.11.71

Tinkers' Construct Version

TConstruct-1.20.1-3.10.2.92

Describe your issue

I am an modpack creator and I found that the fluid volume of one ingot in your module is 90mb, while the volume of one ingot in my modpack is 144mb. How to modify the volume of one ingot in Tinkers Construct to unify

Steps to reproduce

None

Crash Report

No response

Can you reproduce with just Tinkers?

I have not tried

Performance Enchancers

Rubidium/Embeddium

Other mods

GregTechCEu Modern 1.6.4

Searched for known issues?

Checked the FAQ

commented

You are better off not doing that. You would have to change thousands of recipes.

commented

You change every single recipe that uses it.

90mb is the current standard for ingots. It makes 10mb nuggets, meaning 1000mb (1 bucket) is 100 nuggets. At 144mb ingots, you get 16mb nuggets meaning 1 bucket is 62.5 nuggets. No one wants 62.5 nuggets. 144mb ingots is bad for gameplay. GregTech uses an outdated and frankly bad standard.

My recommendation is to change GregTech recipes to use the new standard. But if you would rather not, I recommend writing a script that iterates our recipes and multiplies the amounts by 16/10 if the fluid is in a list of metal fluids.

That, or just accept that Tinkers molten metals and GregTech molten metals are not the same fluid. Add a machine to convert between the different scales. Call theirs "weirdly less dense molten metals that don't have any reasonable amount of units in a bucket"

commented

Its worth mentioning, one new feature in the next build of Tinkers' Construct is command driven datagen where I iterate the crafting recipe registry and use that to create melting recipes.

It would not be hard to apply the same sort of loop to generate modified recipes from existing recipes in an addon. It would not be as easy as a fork, but means when we release updates you get free support instead of having to update your fork manually.

I'll also note you don't need a fork to change the recipes if you just plan to use our existing datagen. You can easily export just the changed recipes as a datapack.


As an aside, I can't find any modern tech mods that are still on the 144mb standard. I was told in the past GregTech did but they don't tag their fluids same as ours so its just a distinct fluid. This seems like a lot of effort to go to revert to a worse standard.

commented

Its worth mentioning, one new feature in the next build of Tinkers' Construct is command driven datagen where I iterate the crafting recipe registry and use that to create melting recipes.

It would not be hard to apply the same sort of loop to generate modified recipes from existing recipes in an addon. It would not be as easy as a fork, but means when we release updates you get free support instead of having to update your fork manually.

I'll also note you don't need a fork to change the recipes if you just plan to use our existing datagen. You can easily export just the changed recipes as a datapack.

As an aside, I can't find any modern tech mods that are still on the 144mb standard. I was told in the past GregTech did but they don't tag their fluids same as ours so its just a distinct fluid. This seems like a lot of effort to go to revert to a worse standard.

Sir,When I modified the fluidvalues class and executed rundata, I encountered an issue where all generated recipes recipes/tools/parts/casting appeared in both "original" and "modified" versions simultaneously. Surprisingly, both versions had identical recipe IDs. Additionally, the components in each recipe appeared randomly - some showed pre-modification values while others showed post-modification values.

Unable to resolve this problem through other means, I had to implement fork as a solution. This approach not only fixed the recipe generation issue but also correctly displays "one ingot" as 144mb in JEI.

Image Image

Made from 90MB each 1 ingot material

Image Image

Made from 144MB each 1 ingot material
The exact same recipes ID

commented

please ignore modid , its just a nickname :)

commented

I encountered an issue where all generated recipes recipes/tools/parts/casting appeared in both "original" and "modified" versions simultaneously

I have no idea what this means. It sounds to me like you are confused how git works, as datapacks have no concept of original and modified recipes.

If you are seeing two copies of recipes with the same ID, you might just need to reload properly as I've seen the /reload command act weirdly at times with JEI being entirely client side. Leave the world, then rejoin the world.

If you are seeing two copies of the recipe with different IDs, or either of them is not under tconstruct, you did not override the recipe, you created a new recipe.