
Dense: incorrect repair modifier
Ozen27 opened this issue ยท 0 comments
Minecraft Version
1.20.1
Modloader
Forge
Modloader Version
47.4.2
Mantle Version
1.11.71
Tinkers' Construct Version
3.10.2.92
Describe your issue
The "Modifiers and Traits" spreadsheet and the in-game description for the Dense trait both state that repair effectiveness is 75%, 55%, 40%, 30%, 25% for levels 1 to 5. My testing indicates that these values are significantly lower than stated: 33%, 21%, etc.
I checked the mod files and found that the repair efficiency modifier is calculated using the formulas FACTOR * (1 - 0.025 * LEVEL * (11 - LEVEL)) for levels 1 to 5 and FACTOR * (0.5 - LEVEL * 0.05) for levels 6+. My guess is that these formulas are actually applied simultaneously: so it is 0.75 * 0.45 = 0.3375 for Dense I, 0.55 * 0.4 = 0.22 for Dense II, etc. These numbers match the results of my tests in the game.
Steps to reproduce
- Obtain any tool with Dense trait.
- Try to repair it.
- Compare expected and actual values.
Crash Report
No response
Can you reproduce with just Tinkers?
Yes
Performance Enchancers
None of the above
Other mods
No response
Searched for known issues?
Searched open issues