Tinkers Construct

Tinkers Construct

170M Downloads

Tool stat for shield disable time

gjhihihi opened this issue ยท 1 comments

commented

Minecraft Version

1.20.1

Forge Version

36.1.0

Mantle Version

1.11.71

Tinkers' Construct Version

3.10.2.92

Problem description

I want to add a new modifier work as cleaving enchantment from Combat Test in minecraft, but there aren't ways to add shield disable time.

Suggested solution

Add a new tool stat to decide shield disable time.

Alternatives considered

Add cleaving modifier by hardcode and support to transform enchantments from other mods that bring Combat Test back into this modifier.

Additional context

No response

Searched for existing enhancement?

I did not search

commented

This is not something there is a current API for. Shield disabling is a binary, either you disable or you don't. There are apparently some contexts that have chance based shield disabling, but nothing seems to use it in vanilla.

In theory, could reimplement shield disabling from scratch to do such stats, but some mod compatibility would be lost from that likely.

Is worth noting from a code inspection that shield disabling is an exclusively PvP thing. Given that axes in tinkers construct can receive sharpness, there is a lot less space for cleaving in the design, because why take less damage boost to gain shield disabling time in a PvE setting? For PvP, you would likely be better off just writing a modifier that uses the post hit hook to disable shields with a time.