Chest/Inventory check functions with loss of durability if option is TRUE
X-Niter opened this issue ยท 2 comments
Your config options for checking a chest or if a chest is full works in that it won't drop items to the ground, but it doesn't actually stop the farm from functioning.
I've run through all the versions you had this option available and it's the same issue for each one.
The issue exactly is that it will continue to still run which will cause damage to the lasso, so it doesn't actually stop.
Now if you are using the highest tier then it's not that big of a deal, but there is no need for something to keep ticking or running if it's not doing anything.
In my fork/code I've added the chest checking option, on top of actually making the farm stop.
However, I've added this code to your 1.12.2 version as I am currently running a live server in 1.12.2.
I can add this into your other versions, but I'm sure it's super easy for you to see how I did this and you can most likely do this in seconds.
Hi.
This is actually intentional; farms are not supposed to stop when the chest is full, and instead should spit out the loot into the world (the player is encouraged to make a redstone mechanism to automatically stop the farm when full). However the spitting out loot part can be laggy on server, so there is the option to void the loot instead of spitting it out.
Ah okay, that does make sense. I enjoy that you kindly shared your reason as to why it's done the way you have it. Thank you for that.
I do want to note though, that you have the chest checking feature to not drop the items if they are full in your newer versions and I did add that to the 1.12.2 version.
I thought maybe bringing that feature down to the lower version would be nice unless of course, you are opposed to bringing new features like that to your older verions?
If you're okay with me bringing your newer features from your new versions down to the 1.12.2 version, I can revert the code and just keep that new feature in.
Thank you for your respectful communication, hope to continue it.