TIS-3D

TIS-3D

981k Downloads

TIS-3D Translation Chinese

Cyl18 opened this issue ยท 9 comments

commented

Hey!Your mod is amazing!
This is TIS-3D-Translation-Chinese.
TIS-3D Translation Chinese.zip

commented

Oh,I'm sorry.
The manual is not working.(I had not tested.)
The Markdown files are correct, but if I open the manual, the game will crash.
I don't know how to fix it.
untitled

When I repair it,I will make a pull request.

commented

Thanks a lot! Would you mind making a pull request?
(If you don't know how to, see Github's forking and pull requesting guides. If you can't figure it out no worries, I'll look into adding manually when I have the time!)

commented

@Cyl18 Do you have any crash-report(s) or any kinda of log(s)? Otherwise it's just waste of time.
Just tested it by myself, the game will freeze without any useful information generated.
Tested under 1.7.10-Forge10.13.4.1614, with many of other mods installed. If necessary I'll provide the full mods list.
Still have no idea why that happened, and Im trying digging into codes to see if there is something related.

commented

Okay here is what I found.
First, I don't think it is caused by broken translation, because I have double checked the index.md and found no problem.
Second, I set up a new MultiMC instance and installed Forge 10.13.4.1614 and TIS-3D only, switched language to Simplified Chinese and loaded the translation as a resourcepack. This time, I notice that the game seems not to crash - because minecraft is still playing music.
Last but not least, I use VisualVM and notice this:
image
My Java skill is not good enough and I cannot determine whether it is the origin of game freezing. Hope it will be helpful.

commented

@fnuecke Sorry for bothering again, but after I removed all the code segments in index.md, thing still have no change - that said, I suspected that it is something else that freezes game, 'cause I have found that moduleAudio.md and moduleBundedRestone.md has the same problem.
I will keep testing on that until I found the problem.

Edit: After a thorough check on all markdown files, I suspect that the problem is on starting a new line. So far I have manually fixed almost of those broken files. I probably can open a pull request soon or later; however, my friends and I have a strong feeling that the tone and writing style need further review.

commented

Ahh, the font renderer for code segments only has a very limited set of characters. Thanks for digging into that.

I'm guessing it somehow gets locked up when encountering an unknown char, I'll look into fixing that.

However, that will just lead to unrenderable characters to be missing/replaced by ?s, so I'm afraid I'll have to ask you to keep it simple in code segments, sorry.

commented

Allright, fixed the hang!

commented

Ohh, nevermind, I'm an idiot. I got distracted by the mention of the code segment, but the stack in the screenshot clearly says it's in the text segment. I'll investigate and fix it.

commented

@fnuecke "very limited set of characters" ;)

normal.png

(just kidding. the image took a really long time to load, at least a second or so...)