Titles

Titles

6M Downloads

[1.16.5] Minecraft advancement titles in wrong folder

son0fether opened this issue ยท 11 comments

commented

In 1.16.5, titles for vanilla Minecraft advancements do not function with the code as written. However, I made a datapack with the folder structure below, and added it, and the vanilla Minecraft titles worked fine.

I think you need to relocate the minecraft vanilla advancement title jsons in order for them to work. I'm not 100% sure exactly where they'd need to go in your own mod jar. They might need to go in a data/minecraft/ folder next to the high level /data/titles/ folder.

Datapack structure that is letting me use the titles for vanilla advancements from this mod:

[packs]

  • my_pack
    • data
      • minecraft
        • titles
          • adventure (and all the adventure title jsons from the mod jar)
          • end (and all the end title jsons from the mod jar)
          • husbandry (and all the husbandry title jsons from the mod jar)
          • nether (and all the nether title jsons from the mod jar)
          • story (and all the story title jsons from the mod jar)

Thank you for this mod.

commented

Thanks for posting this! I apologize for the late response. Are you using a custom modpack or a pre-built one? You're the first person who has mentioned this issue, so I am just wondering if it is an edge case due to your setup or something else.

commented

Apologies, let me clarify what I mean by "not working". The titles related to vanilla Minecraft advancements, such as 'the Huntsman/Huntress' for 'Monster Hunter'/killing a mob, do show in the autocomplete for the '/titles add [player] ...' command, so they do exist in the game as the mod is currently written. They can be added and removed from players by /titles commands. However, they are not granted when the respective vanilla Minecraft advancements are earned. That's the bug, and repositioning the files in the way I've described fixed that.

The directory structure where I placed those files actually came from the documentation in the mod for adding additional titles, so thank you for good documentation there. I've used it to add even more titles.

This bug can be tested pretty easily by using the /advancements command to grant titles or by earning easy advancements for which there are titles.

Regarding my testing setup for how I retested it, I consider the experience I had to be about as generic as possible:

  • The CurseForge modpack builder, fresh modpack
  • The newest version of forge for 1.16.5
  • The newest external version of the Titles mod
  • Single player
  • No other mods

I think this is completely unrelated to that other bug, as that one prevents a lot more functionality and only applies to multiplayer.

commented

I'm in 1.16.5 with about 90 mods. I made this pack. https://www.curseforge.com/minecraft/modpacks/the-slow-magics

commented

The repro would be to load just titles and run /advancements grant to grant some vanilla advancements and see if you get titles. I can also try that at some point soon.

commented

If you could, and then post the debug.log file, that would be extremely helpful. Remember to post the log as a pastebin or similar link.

commented

The problem reproduces easily with Titles all by itself. Here's a pastebin of latest.log. I'm not sure if there's some way to get a separate debug.log, but it's trivial to reproduce.
https://pastebin.com/8zXnwcdx

commented

It may happen to you every time, but I have no issues with earning titles in my dev environment, nor my external testing world. You should be able to find the debug log in the same folder as you found the latest log. It prints out a lot more info which will be helpful in figuring out what difference there is that's causing this issue for you.

commented

And I am beginning to wonder if this is related to the other pending issue #26...

commented

There's no other log files in that folder for me. If there's a way to enable it, I don't know.

commented

Let me do some more research and try to figure it out. I'll get back to you if I learn something.

commented

Though I didn't find anything specific to cause this, go ahead and see if this issue persists in the latest version of the mod and let me know!