Strange Spark Change
Krimatoria opened this issue · 8 comments
What operating systems are you seeing the problem on?
Windows
What the loader are you seeing the problem on?
Forge
Describe the bug
Somehow Palladium changes the values in the Spark report in TPS and other parameters. I've tried different versions of Palladium up to 1.0.4, but the problem persists. I didn't see a direct error with Palladium only in combination with other mods in the mixins.
+Palaldium
-Palladium
Steps to reproduce
- Forge 1.20.1 47.3.22
- Spark-1.10.53-forge.jar
- Palladium-1.20-1.20.4-1.0.4.jar
What version of the palladium are you using?
1.0.4-1.0.9.3
I recently received an email about a problem similar to this one, but on ToadLib. And I think that ToadLib is involved in this problem because it adds ChunkTickEvent(And it is related to TPS).
I will test Palladium and ToadLib and also try to fix this bug/make integration with Spark.
I recently received an email about a problem similar to this one, but on ToadLib. And I think that ToadLib is involved in this problem because it adds ChunkTickEvent(And it is related to TPS). I will test Palladium and ToadLib and also try to fix this bug/make integration with Spark.
In my Spark report with incorrect values, there are only Palladium ticks. Toad Lib is not displayed in them. But it's great that this can be fixed, as Palladium improves TPS. By the way, the value highlighted with the mouse is more orange, although there is a very small percentage. It is apparently involved in many processes.
By the way, the value highlighted with the mouse is more orange, although there is a very small percentage. It is apparently involved in many processes.
This is a de-duplication of different values(I plan to improve it in an upcoming update).
The spark and toadlib conflict will definitely be resolved. The top ChunkEvent(which is called before the minecraft chunk tick) is causing all these problems, if I can't even fix the top one, I can only keep the bottom method.
I made Spark compatibility but I don't know how well it works, the code will be later(I have 1am now ._.)
Palladium 1.1.0 toadlib 1.2.1.2
So far, the problem persists, however, after adding mods and stopping Spark and exiting the game. It kind of freezes and has to be closed through the task manager. But the settings in ToadLib are working.