Tomb Many Graves 2

Tomb Many Graves 2

Mods
16M Downloads

Grave Fails to Find Suitable Location in the Deep Dark

NielsPilgaard opened this issue · 3 comments

commented

Describe the bug
A grave fails to spawn when dying in The Deep Dark dimension, from Extra Utilities 2. This happens in the modpack Enigmatica 2: Expert version 1.50a

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Deep Dark, by standing on a Deep Dark Portal
  2. Use the command /kill
  3. See error

Expected behavior
A grave to spawn at the place of death.

Screenshots
billede

commented

Still happens

commented

I doubt Extra Utilities would update, even if they're at fault tbh :)

commented

I did some investigating. The grave fails to spawn because of this line

TombManyGraves2/src/main/java/com/m4thg33k/tombmanygraves/events/CommonEvents.java

Line 224 in f98cfdb

if (pos.getY() < 0 || pos.getY() >= world.getActualHeight()) {

the call world.getActualHeight() returns 128 while the deep dark's max height is 255. I confirmed this by going below 128 where it does indeed spawn a grave. I'll attempt to fix this myself if possible. The fault may lie with Extra Utilities but I need to investigate the getActualHeight() code more to determine that

  • 👍1