Grave item list can cause extremely huge NBT files, players can't join/get kicked

Question

Grave item list can cause extremely huge NBT files, players can't join/get kicked

aaronhowser1 opened this issue 6 years ago · 3 comments

aaronhowser1 commented 6 years ago

Describe the bug
If you die with death list, the NBT tag grows exponentially. If you had tinkers tools on you, it grows even faster. Normal player NBT file is around 3KB, these easily get over 40KB. Once it reaches 64K, players can no longer join

Column01 · Answer 1 · 2020-02-09T10:40:08.000Z

I also have this issue on my server. I attached a zip archive of stuffed player data and one after editing to show you the problem. If you were to blacklist the death lists from the listing, it would solve this.
playerdata.zip

Column01 · Answer 2 · 2020-02-09T10:57:27.000Z

Also appears that the config option to disable the deathlists doesn't actually work...
No check for it here
or during the death event here
it happens in onPlayerClone but the lists still spawn despite the config being set to false for it.

Column01 · Answer 3 · 2020-02-09T11:25:59.000Z

@aaronhowser1 We patched the getDeathListFromFile to return null using ModPatcher to stop them from spawning and it seems to work. If it becomes a big issue for you, I suggest doing this till the mod author can fix it properly.

Share to