Tomb Many Graves

Tomb Many Graves

3M Downloads

Incompatibility With Natural Pledge

gr8pefish opened this issue · 11 comments

commented

The Return Stone apparently conflicts with this mod.

I believe you simply need to turn down your event priority to fix this.

CC'ing @yrsegal for clarification.

commented
commented

@yrsegal I'm not going to be able to drop it all the way to lowest; I can drop it down to LOW though. I believe I still need to be one priority above Iron Backpacks in order for compatibility with the eternity upgrade to work; that's what we decided, right @gr8pefish?

commented
commented

How exactly does the return stone work? It looks like it gathers the player's coordinates on death and then stays in the player's inventory? If so, I can just have the grave blacklist that item so it doesn't attempt to be gathered in.

commented
commented

I haven't found a good way to have the grave keep its replacement property while conforming to the standard of other grave mods (since the drop-item event doesn't keep track of what slot from which it was dropped), so I have to default to adding compatibility for every mod that adds special behavior. The next iteration of the mod should include a config for items to blacklist from graves to make this sort of compatibility a tad bit easier.

commented
commented

I agree, a config seems like a good middle ground here. I believe my soulbound equivalent is at NORMAL priority now, though I'd have to check my source code to be sure.

commented

The next update will include the blacklist feature and will default to including this stone.

On a side note, I was actually planning to add a feature similar to what the stone does to the death list from TMG (since they already inherently store the grave's location). Do you have any problem with me referencing your code for that, @yrsegal?

commented

No, go right ahead. Do be warned it's in kotlin, though... 😅

commented

I noticed it wasn't java, but that shouldn't be an issue. :-) It's just easier to work off something that already exists (and works). Thanks!