Tom's Simple Storage Mod (Fabric)

Tom's Simple Storage Mod (Fabric)

16M Downloads

Advancement not granted when using the crafting terminal

630R63 opened this issue ยท 1 comments

commented

Hello!

Currently playing the Better Minecraft [FABRIC] modpack for 1.19.2.
The modpack is using the fabric version 1.5.4 of this mod.
Been trying to get an advancement from the mod The Bumblezone in which you have to craft 24 beehives or bee nests.

Crafting them using the Crafting Terminal, didn't grant the advancement:
image
image
image

When using the crafting table to craft the beehives, I did get the advancement:
image

The Bumblezone mod author was thinking that this should work for any crafting method or recipe that has a Beehive or Bee Nest as result. Only way it won't work is if you're using some sort of custom crafting system that is not using a ResultSlot or they forgot to fire checkTakeAchievements method upon taking items out of their custom system's ResultSlot.

So since the interface has a ResultSlot, maybe the advancement check is not triggered? Could you please check?

Thank you!

commented

This is the method that the Crafting Terminal's result slot should be firing when a players crafts and removes the result item from the ResultSlot to properly grant advancements and update item craft stat too. If not using the vanilla ResultSlot here, maybe extend that slot to implement the behaviors you want while underlying checkTakeAchievements still runs for best mod compat when they may be hooked into that method
image