Tom's Simple Storage Mod (Fabric)

Tom's Simple Storage Mod (Fabric)

18M Downloads

[Feature Request] Tag support for configs

Tidy-Bear opened this issue ยท 3 comments

commented

Let some config entries support Tag, including multiblockInv, blockedMods, blockedBlocks, etc.

For example:

# Every Compat adds lots of drawers with modded wood.
blockedBlocks = ["#storagedrawers:drawers"]
commented

On 1.21+ there is a tag: toms_storage:inventory_connector_skip which works the same way as the config does.
You have to make a datapack and load it with a datapack loader mod or manually.

commented

On 1.21+ there is a tag: toms_storage:inventory_connector_skip which works the same way as the config does. You have to make a datapack and load it with a datapack loader mod or manually.

Oh, I see. Unfortunately, I'm playing a modpack for 1.20.1.
Anyway, using tags instead of the config is indeed more in line with vanilla. Maybe the new "blockedBlocks" config could follow suit.
Since settings were in the config file before, it'd be helpful to add a note there about the new expansion method.

commented

On 1.21+ there is a tag: toms_storage:inventory_connector_skip which works the same way as the config does. You have to make a datapack and load it with a datapack loader mod or manually.

Sorry, I misunderstood that toms_storage:inventory_connector_skip functioned the same as multiblockInv until I just tested on 1.21.

First of all, the newly added blockedMods and blockedBlocks work as expected on both 1.21 and 1.20.1. Once connector detects one of the blocked blocks, it will stop the detection. (break logic)

On 1.20.1, when I add create:item_vault to multiblockInv, the connector can connect the first-detected vault block and the barrel behind the vaults. (continue logic)
Image

On 1.21, when I add create:item_vault to the tag toms_storage:inventory_connector_skip, the connector cannot connect any of the vaults or the barrel behind them. (break logic, which is duplicated with blockedBlocks)
Image
In this case, players have to use cable connectors for multiblock inventory after 1.21.

Edit:
It's a bit embarrassing, but I've just learned that the inventory configurator allows for area selecting, making multiblock inventory be regarded as a single storage by connectors, and it comes with other new features. (So slow of me)
However, since the "skip" term is in the tag, it seems a bit odd that connectors follows a break logic rather than a continue logic. Is this the intended design?