Tom's Simple Storage Mod (Fabric)

Tom's Simple Storage Mod (Fabric)

18M Downloads

[bug] Incompatible with JeCH

Closed this issue ยท 2 comments

commented

Hello, Your implementatin of search box seems not working well with JeCH (https://www.curseforge.com/minecraft/mc-mods/just-enough-characters) which allows Chinese user to search item with the Pinyin.

Here is a corresponding Issue link from JeCH github repo (Towdium/JustEnoughCharacters#34 (comment))

commented

The mod has to update the compatibility.
https://github.com/Towdium/JustEnoughCharacters/blob/1.21/generate.yaml#L108
The class was renamed and the matchers are now in lambdas.

'com.tom.storagemod.screen.AbstractStorageTerminalScreen:lambda$updateSearch$16(Ljava/util/regex/Pattern;Lcom/tom/storagemod/inventory/StoredItemStack;)Z'
'com.tom.storagemod.screen.AbstractStorageTerminalScreen:lambda$updateSearch$15(Ljava/util/regex/Pattern;Lcom/tom/storagemod/inventory/StoredItemStack;)Z'

These should work on 1.21

commented

To any newcomer: PR sumbited for JeCH.
Towdium/JustEnoughCharacters#152