Hello,

To reproduce the performance issue install Tom Storage mod and Create mod both latest versions available on 1.19.2 Fabric MC version (probably applies to NeoForge too but that was my test env)

Create a 250k slots storage (extreme situation but really makes the performance issue obvious), on average Create mod usage with 15k slots, the issue is already visible with locations taking 1/3 of the 50 MSPT budget just for 1 player who is using tom storage with Create mod.

Place an inventory connector next to this 250k slots storage, then wire an inventory cable to an inventory cable connector on top of a smart chute from Create mod which leads into anything like a chest, as soon as the inventory cable connector is placed the performance issue starts and the game really lags alot, if you destroy the inventory cable connector, it goes back to normal immediately. You don't need to fill the storage, even if it's empty it will lag.

To create 250k slots storage, I used expanded storage mod but I believe it doesnt matter which storage, just number of slots counts.

Overall it has been difficult to automate anything that has to do with a storage of more than 10k slots because the moment I start automatically taking items from this storage no matter how (inventory hopper, cable connector filtered or not, all lag equally), it starts lagging the server.

For now, in some areas we have split the main storage from the "factory" storage and made it a much smaller inventory of less than 1k slots and it works faster but it loses all the potential of automatically processing items that you put in your main storage and we now need to manually give items specially to the factories due to this performance problem and it's not really convenient.

If this issue was not known, I will be glad to provide more precise details but for now this is the best reproduction scenario I have made. I will try to upload a test world soon if possible.

This issue is plaguing our server we are considering removing tom storage for it because using Create mod's own ways of moving items across inventories does not cause any significant lag even though it's much more cumbersome, it's just when it interacts with tom storage that it lags. We are concerned because everyone started using Tom Storage and it works great and very convenient but the more we use it the more our server is becoming very laggy.

With your expertise in the code base, if that performance problem leads to a specific area of the code, I would like to know and then I can work on optimizing those code paths.

Thanks

The 1.21 version was a rewrite and it fixed the issues with massive inventories.
The older versions do not like massive inventories though, mainly due to how Minecrafts inventory system works.

Good to know that it was fixed cause I was going to open a bug for it but too bad my servers still on 1.20.1, ill just blacklist the quark crates which is the cause of the issue.