Tool Progression

Tool Progression

3M Downloads

Overwrites for Thermal Foundation tools don't work

tyra314 opened this issue ยท 12 comments

commented

Yeah the mod worked just fine before but I also updated forge on that update so that could have been what broke it, I'll do more testing.

commented

Sorry, running on very little sleep. The only thing not working as intended is tool overwrites. I have Thermal Foundation steel pickaxe set to a mining level of 6 and it shows up in JEI and in inventory as level 2. I also have other tools showing incorrect mining levels as well. Block overwrites are working. Material overwrites are setup to match the tool overwrites. I made a repo here to show what I have right now.

commented

From a quick look, this is definitely wrong: https://github.com/Sixdd6/reimagined-octo-meme/blob/master/tool_progression/tool_overwrites.cfg#L15

The other entries look fine. I try loading Thermal Foundation in my dev env.

commented

I'll fix that and try again

commented

I changed it but the thermal foundation tools are still showing wrong mining levels as well as the redstone arsenal Fluxed Pickaxe.

commented

Yeah... I found the issue. Could never have worked for Thermal Foundation tools. It has it's one little harvest level implementation... REEEEEE

https://github.com/CoFH/CoFHCore/blob/d4a79b078d257e88414f5eed598d57490ec8e97f/src/main/java/cofh/core/item/tool/ItemToolCore.java#L44

commented

But doesn't this here mean that the tools get their mining level from the material rather than being set directly?

commented

Yes, but this still doesn't work

*Edit: Can you confirm, this only affects ThermalFondation tools?

commented

Digging deeper, those Items are initialized with the Material in the TF preInit event. Material overwrites are applied in TPr postInit event, no way I could catch that. Working on a compatibility module for setting harvest levels on CoFhCore tools at least.

commented

ok thank you :D
If needed I can help test, just going to bed now though

commented

Should be fixed in the upcoming release v1.4.5

There are limitations though. You can't remove a tool class from a given TF tool. If you want to use the material level for some reason, just overwrite the tool with the level -1, this way material levels are used.

commented

So, are the config files populated? Got they replaced? Are we talking about block, material or tool overwrites?